Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Views moved to panel do not open on reload #89567

Closed
JacksonKearl opened this issue Jan 28, 2020 · 3 comments
Closed

Views moved to panel do not open on reload #89567

JacksonKearl opened this issue Jan 28, 2020 · 3 comments
Assignees
@sbatten
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken verified Verification succeeded workbench-views Workbench view issues
Milestone
January 2020

Comments

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Jan 28, 2020 •
edited

testing #89384

Have search in panel, and have it be the active panel entry. Reload. Now some other panel item is active (for me, Terminal). Similar happens with Outline/etc. I think persisting the active panel is important.
@JacksonKearl JacksonKearl changed the title Panel search no longer opens on reload Views moved to panel do not open on reload Jan 28, 2020
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug regression Something that used to work is now broken workbench-views Workbench view issues labels Jan 30, 2020
@sandy081 sandy081 added this to the January 2020 milestone Jan 30, 2020
@sandy081
Copy link
Member

I also see this with other custom views. Marking this as regression because it used to work for Search view.

@sbatten
Copy link
Member

sbatten commented Jan 30, 2020

@sandy081 added the behavior that viewlet has to panel where its openViewlet api is async to wait for extension load. I made it a separate api to limit impact for endgame, but I will make a debt item to remove the non-async version after release.

@sbatten sbatten mentioned this issue Jan 30, 2020
Closed
@sbatten sbatten added the candidate Issue identified as probable candidate for fixing in the next release label Jan 30, 2020
@sandy081
Copy link
Member

Makes sense

@sandy081 sandy081 added the verified Verification succeeded label Jan 31, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken verified Verification succeeded workbench-views Workbench view issues
Projects
None yet
Milestone
January 2020
Development

No branches or pull requests
3 participants
@sbatten @JacksonKearl @sandy081