Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: "files.defaultLanguage": "${activeEditorLanguage}" #89233

Closed
2 tasks done
bpasero opened this issue Jan 24, 2020 · 3 comments
Closed
2 tasks done

Test: "files.defaultLanguage": "${activeEditorLanguage}" #89233

bpasero opened this issue Jan 24, 2020 · 3 comments

Comments

@bpasero
Copy link
Member

bpasero commented Jan 24, 2020

Refs: #78903

Complexity: 2

Steps:

  • configure "files.defaultLanguage": "${activeEditorLanguage}" in settings
  • verify that each untitled file you open will take the language mode from the currently active file if any
  • verify this setting is suggested in settings help and its description makes sense
@miguelsolorio
Copy link
Contributor

This works really well 👏. Any thoughts on making ${activeEditorLanguage} the default? I really like that it defaults to plain text when there aren't any active editors.

@miguelsolorio miguelsolorio removed their assignment Jan 28, 2020
@bowdenk7
Copy link

bowdenk7 commented Jan 28, 2020

👍 - not sure about making it the default because I know a lot of people use it as a notepad substitute, and depending on what kind of language service you get it's really distracting:

image

@bowdenk7 bowdenk7 removed their assignment Jan 28, 2020
@bpasero
Copy link
Member Author

bpasero commented Jan 29, 2020

This works really well 👏. Any thoughts on making ${activeEditorLanguage} the default? I really like that it defaults to plain text when there aren't any active editors.

I am also not 100% sure this is good to do. Given we also now automatically flip the mode as soon as you copy/paste text, I think it gets less likely that you end up in text mode and not in a specific mode.

@bpasero bpasero closed this as completed Jan 29, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants