Keyboard shortcut chords can be quietly overridden

[derekyle]

Issue Type: Bug

I had an issue where none of my keyboard shortcut chords that started with Ctrl + K worked correctly. I finally discovered that it was because I had an extension that was triggered with Ctrl + K alone. The extension action was context dependent so it would never trigger and tip me off to the problem.

Allowing the first part of a chord to be set to an action negates all other chords that start with that combo. So it seems that vs code should warn or not allow this. I finally solved it by manually searching through all the shortcuts with ctrl + k in them and found the one that was just ctrl + k by itself and removed.

VS Code version: Code 1.41.1 (26076a4, 2019-12-18T14:58:56.166Z)
OS version: Windows_NT x64 10.0.18362

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Problem saving keybindings (#25356)
• Add suggested completions for key chords (#3969)

[alexdima]

I can see how this is highly annoying. But please create an issue against the extension. It is bad practice for an extension to ship with a keybinding which overrides tens of chords.

As far as VS Code goes, this is as designed. All the default VS Code keybindings can be overwritten from extensions. In fact, that is how the VS Code keymap extensions work, they change tens and hundreds of default keybindings, including chords, etc.

In this specific case, you did the perfect thing, you searched for "Ctrl+K" in the keybindings UI and found the culprit. Please create an issue against the extension.

[derekyle]

The extension didn't create the keybinding. I created it myself, not knowing at the time that Ctrl K was commonly used in chords. I opened the issue on vs code because it seems that the vs code UI should warn when a bunch of chords are going to be rendered inaccessible.

…

On Mon, Jan 20, 2020, 8:42 AM Alexandru Dima ***@***.***> wrote: Closed #88488 <#88488>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#88488?email_source=notifications&email_token=AAQ3CY7UTUS45ZZEHBN65GDQ6XH5PA5CNFSM4KFTWIEKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWCSPSKI#event-2963601705>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ3CY5DZ3KVKCTUUQZPV6LQ6XH5PANCNFSM4KFTWIEA> .

[alexdima]

@sandy081 In this case, when using cmd+k I see that we show "1 existing command..." but it should show a lot larger number, to include all the chords at cmd+k as well:

[sandy081]

/duplicate

#88122

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!