Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle between default and custom editors #86504

Closed
sverg1 opened this issue Dec 7, 2019 · 2 comments · Fixed by #86505
Closed

Toggle between default and custom editors #86504

sverg1 opened this issue Dec 7, 2019 · 2 comments · Fixed by #86505
Assignees
Labels
help wanted Issues identified as good community contribution opportunities markdown Markdown support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@sverg1
Copy link
Contributor

sverg1 commented Dec 7, 2019

Background

This is a subtask of #84520 involving a keybinding that toggles between the default editor of a file and its custom editor (if applicable). The goal is to add flexibility between different view modes without having to force views such as in the example below.

Example

Pertaining to the aforementioned parent issue in particular, one can force the custom Markdown preview mode by adding the following experimental setup to settings.json:

"workbench.experimental.editorAssociations": [
    {
        "viewType": "vscode.markdown.preview.editor",
        "filenamePattern": "*.md"
    }
]

Save-to-Preview

Using another keybinding, the user can save the file and switch to the custom editor all in one command. For example, saving in a Markdown file may automatically switch to its preview mode so that the user can see the final look of the file with each edit.

@vscodebot
Copy link

vscodebot bot commented Dec 7, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot assigned mjbvz Dec 7, 2019
@vscodebot vscodebot bot added the markdown Markdown support issues label Dec 7, 2019
@mjbvz mjbvz added the help wanted Issues identified as good community contribution opportunities label Dec 7, 2019
@mjbvz mjbvz reopened this Dec 10, 2019
@mjbvz mjbvz closed this as completed Dec 10, 2019
@mjbvz mjbvz added this to the December/January 2020 milestone Dec 10, 2019
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Dec 10, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Dec 10, 2019

This ended up being implemented as a single: editor.action.customEditor.toggle command

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 24, 2020
@connor4312 connor4312 added the verified Verification succeeded label Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Issues identified as good community contribution opportunities markdown Markdown support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants