Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings UI: Can't configure Default Dark+ in the workspace settings if theme is already set in user #84943

Closed
DiegoBM opened this issue Nov 15, 2019 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@DiegoBM
Copy link

DiegoBM commented Nov 15, 2019

Issue Type: Bug

  1. Go to User Settings and set a color theme different than the default one, for example "Kimbie Dark"
  2. Go to Workspace Settings and set "Default Dark+"
  • Expected Result: Use the "Default Dark+" color theme for the current workspace/folder/project
  • Current Result: Uses the "Kimbie Dark" color theme for the current workspace/folder/project.

If you make Workspace Settings' color theme point to any color theme other than "Default Dark+", it will work just fine. It seems like the "Default Dark+" color theme is not a color theme itself (even though it seems to have its own and unique syntax and interface styles) but a pointer to "default", and "default" is whatever value that is selected in User Settings.

We should be to be able to use the "Default Dark+" color theme for certain projects, regardless of the color theme selected globally in User Settings

VS Code version: Code 1.40.1 (8795a98, 2019-11-13T16:49:35.976Z)
OS version: Windows_NT x64 10.0.18363

Extensions (4)
Extension Author (truncated) Version
numbered-bookmarks ale 6.2.1
remote-wsl ms- 0.40.3
cpptools ms- 0.26.1
material-icon-theme PKi 3.9.1

(1 theme extensions excluded)

@aeschli
Copy link
Contributor

aeschli commented Nov 18, 2019

It's a bug in the settings UI. I says Default Dark+ is the default, which is not really correct when the user settings have a different theme set (maybe Kimbie Dark should get the default label?). So clearing the setting doesn't result in having the Default Dark+ theme.

@aeschli aeschli assigned roblourens and unassigned aeschli Nov 18, 2019
@aeschli aeschli changed the title Incorrect Workspace color theme for Default Dark+. Settings UI: Can't configure Default Dark+ in the workspace settings if theme is already set in user Nov 18, 2019
@vscodebot vscodebot bot removed the new release label Nov 18, 2019
@roblourens
Copy link
Member

Dupe of #58038

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 19, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants