Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing Ctrl+W on release notes closes the window #82670

Closed
bancek opened this issue Oct 16, 2019 · 5 comments · Fixed by #84967
Closed

Pressing Ctrl+W on release notes closes the window #82670

bancek opened this issue Oct 16, 2019 · 5 comments · Fixed by #84967
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux verified Verification succeeded webview Webview issues
Milestone

Comments

@bancek
Copy link

bancek commented Oct 16, 2019

Issue Type: Bug

Open a new window, close the Untitled tab, open Release notes and press Ctrl+W (or Cmd+W) on macOS.

Expected:
Release notes tab is closed.

Actual:
Release notes tab is closed as well as the current window.

You can also open a file, open Release notes and press Ctrl+W. Release notes and the last file will close.

VS Code version: Code 1.39.2 (6ab5985, 2019-10-15T15:33:40.634Z)
OS version: Linux x64 4.15.0-65-generic

@Anamika28
Copy link

I tried reproducing the issue, seems everything is working fine.

@mjbvz mjbvz self-assigned this Oct 16, 2019
@vscodebot vscodebot bot removed the new release label Oct 20, 2019
@mjbvz mjbvz added the linux Issues with VS Code on Linux label Oct 25, 2019
@mjbvz mjbvz added the webview Webview issues label Oct 25, 2019
@onequid
Copy link
Contributor

onequid commented Nov 13, 2019

The same happened when closing opened images.
Using "Ctrl+W" to close an image would 1)close another file if there is, 2) otherwise close current VSCODE window
OS version: Linux Mint 19.2 Tina (Cinnamon)/ XM Linux live(XFCE) image on VM
VS Code version: 1.40.0 and the insider version

Also I tried to reproduce it on a Windows 7 VM, and it was not there.
Is it caused by Electron by any chance?

I'd love to try to fix it. However, yet have no clue on where the related lines of codes are located. Any hints or suggestions? Thanks

@mjbvz
Copy link
Contributor

mjbvz commented Nov 19, 2019

Reopening since the fix caused regressions and had to be reverted

@DavideViolante
Copy link

DavideViolante commented Apr 13, 2020

I confirm this is still happening with vscode v1.44.0 and Ubuntu 18.04. Many similar issues are opened already: #82670, #86790

@mjbvz
Copy link
Contributor

mjbvz commented Apr 17, 2020

Should be fixed by dbc7b4d

@mjbvz mjbvz closed this as completed Apr 17, 2020
@dbaeumer dbaeumer added the verified Verification succeeded label Apr 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux verified Verification succeeded webview Webview issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants