Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chords to "show same keybindings" #80181

Closed
jabacchetta opened this issue Sep 1, 2019 · 6 comments · Fixed by #170115
Closed

Add chords to "show same keybindings" #80181

jabacchetta opened this issue Sep 1, 2019 · 6 comments · Fixed by #170115
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders keybindings-editor Keybinding editor issues papercut 🩸 A particularly annoying issue impacting someone on the team verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@jabacchetta
Copy link

Currently, to find conflicts caused by a chord, you need to search for the first sequence, without any quotes. This works, but since the search is global across all four columns of information for each keyboard rule, it brings up a variety of commands that you're not interested in. Additionally, it's probably not an obvious way to find conflicts for most VSCode users.

I wonder if "Show Same Keybindings" should not only show the exact same keybindings, but also any keybindings where the first sequence of a chord matches. Alternatively, there could be a second option added to the context menu that does this.

@vscodebot
Copy link

vscodebot bot commented Sep 1, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@sandy081 sandy081 added feature-request Request for new features or functionality keybindings-editor Keybinding editor issues labels Sep 2, 2019
@sandy081
Copy link
Member

sandy081 commented Sep 2, 2019

I like the idea of having separate entry/mechanism to look for keybindings containing keys.

@sandy081 sandy081 added this to the Backlog milestone Sep 2, 2019
@sandy081 sandy081 added the help wanted Issues identified as good community contribution opportunities label Sep 2, 2019
@jabacchetta
Copy link
Author

@sandy081 Similarly, when editing a keybinding through the keybinding edit widget, when it warns you with "x existing commands have this keybinding", it should probably also warn you if that keybinding is not a chord, but it appears in an existing chord sequence, which again, has the potential for conflicts.

With the two options being that those chord conflicts are either added to the existing warning count, or an additional warning is added with its own count.

@trylaarsdam
Copy link

Definitely. Some sort of mode (or at least an obvious switch) to search for first strokes in a chord would be amazing.

@sandy081 sandy081 added the papercut 🩸 A particularly annoying issue impacting someone on the team label Dec 27, 2022
@sandy081 sandy081 mentioned this issue Dec 27, 2022
sandy081 added a commit that referenced this issue Dec 27, 2022
@sandy081 sandy081 modified the milestones: Backlog, January 2023 Dec 27, 2022
@sandy081 sandy081 removed the help wanted Issues identified as good community contribution opportunities label Dec 27, 2022
sandy081 added a commit that referenced this issue Dec 27, 2022
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Dec 27, 2022
@heartacker
Copy link
Contributor

great

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 3, 2023
@sandy081 sandy081 added the verification-needed Verification of issue is requested label Jan 23, 2023
@sandy081
Copy link
Member

To verify:

  • Enable Record Keys option in the Keyboard Shortcuts editor available in the search box
  • Type cmd+k
  • Make sure all commands with cmd+k chord are shown. If you have a command with exact cmd+k keybinding, that shall also be shown.

@jrieken jrieken added the verified Verification succeeded label Jan 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders keybindings-editor Keybinding editor issues papercut 🩸 A particularly annoying issue impacting someone on the team verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants