Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persisted data breakpoints are not reapplied #79895

Closed
weinand opened this issue Aug 27, 2019 · 2 comments · Fixed by microsoft/azuredatastudio#7206
Closed

persisted data breakpoints are not reapplied #79895

weinand opened this issue Aug 27, 2019 · 2 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
August 2019

Comments

@weinand
Copy link
Contributor

weinand commented Aug 27, 2019 •
edited

Testing #79799

  • create a data breakpoint and verify that it works
  • stop debug session
  • start debug session
  • try to hit data breakpoint again

Observe: breakpoint is not hit

When debugging this I noticed that mock-debug's setDataBreakpointsRequest is not called at all.

(And yes, mock-debug by default returns a "canPersist" value of true).
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Aug 27, 2019
@isidorn isidorn added this to the August 2019 milestone Aug 27, 2019
@isidorn
Copy link
Contributor

isidorn commented Aug 27, 2019

Assigning to August to investigate furhter.

@weinand weinand changed the title persisted data breakpoints are not registered persisted data breakpoints are not reapplied Aug 27, 2019
@isidorn
Copy link
Contributor

isidorn commented Aug 28, 2019

@weinand Great catches wrt data breakpoints. Thanks a lot for nicely testing.

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Aug 28, 2019
hunghw pushed a commit to hunghw/vscode that referenced this issue Aug 28, 2019
@isidorn @hwhung0111
fixes microsoft#79895
119b6f4
@weinand weinand added the verified Verification succeeded label Aug 29, 2019
@anthonydresser anthonydresser mentioned this issue Sep 13, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
August 2019
Development

Successfully merging a pull request may close this issue.

Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 microsoft/azuredatastudio
2 participants
@weinand @isidorn