Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximize panel command #7314

Closed
fegg opened this issue Jun 7, 2016 · 6 comments
Closed

Add maximize panel command #7314

fegg opened this issue Jun 7, 2016 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality ux User experience issues
Milestone

Comments

@fegg
Copy link

fegg commented Jun 7, 2016

  • VSCode Version: 1.2.0
  • OS Version: Mac OS X 10.11.6

Steps to Reproduce:

  1. open the terminal function, use: ⌃`

today update version 1.2.0, terminal function is very great! but could add it max zoom panel function? switch this panel and code’s panel because git diff function code is very many, needs more zone to preview diff's code. my english is not well, hope your know what I mean, thanks~

and sometime terminal is not work... show the terminal panel is block.

@Tyriar Tyriar changed the title vscode 1.2.0 terminal function suggest Add maximize panel command Jun 7, 2016
@Tyriar Tyriar added feature-request Request for new features or functionality workbench terminal Integrated terminal issues labels Jun 7, 2016
@bpasero bpasero added this to the Backlog milestone Jun 7, 2016
@bpasero bpasero added the ux User experience issues label Jul 2, 2016
@bpasero bpasero assigned stevencl and bgashler1 and unassigned bpasero Jul 2, 2016
@bgashler1
Copy link
Contributor

Related #2806

@stevencl
Copy link
Member

stevencl commented Aug 4, 2016

Right now we are not keen on adding controls to maximise, minimise and restore the horizontal panel (which contains the terminal) as we are wary of overloading the product with too many window management controls. We think that this would end up making VS Code feeling more bloated and less lightweight.

We do allow you to drag the horizontal splitter to approximately 90% of the height of the main window so that you can provide more space for the panel. Is this sufficient?

@stevencl stevencl closed this as completed Aug 4, 2016
@Tyriar
Copy link
Member

Tyriar commented Aug 16, 2016

@stevencl just noticed that this was closed after looking at #10546. I was going to say that the only other case when I need another terminal is if I want to look at a git diff, in which case I typically launch an external terminal (ctrl+shift+c) and full screen it temporarily. I was hoping this would enable me to stay in vscode by allowing me to toggle a panel fullscreen/maximize state temporarily.

I would be happy with a command that had no keybinding by default, this wouldn't cause bloat. Using the horizontal splitter is not an option for me, taking my hands off the keyboard and resizing it is a huge pain, especially since the hit box for the splitter seems to be 3 pixels high.

@isidorn
Copy link
Contributor

isidorn commented Oct 7, 2016

This has been added to our october plan, thus reopening, assigning to me and october
I have some ideas on how to do this - and we can discuss them on next wednsday ux meeting
fyi @egamma @kieferrm

@isidorn isidorn reopened this Oct 7, 2016
@isidorn isidorn removed the terminal Integrated terminal issues label Oct 7, 2016
@isidorn isidorn modified the milestones: October 2016, Backlog Oct 7, 2016
@isidorn isidorn assigned isidorn and unassigned stevencl and bgashler1 Oct 7, 2016
@wilrnh
Copy link

wilrnh commented Oct 13, 2016

I like the idea of a command with no default keybinding 👍

@kdheepak
Copy link

kdheepak commented Nov 15, 2017

Is this a feature available in release currently?

Edit: I see. I misunderstood. I thought this issue was about a 100% panel as opposed to ~90%.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality ux User experience issues
Projects
None yet
Development

No branches or pull requests

8 participants