Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Default Light+Theme contrast #72550

Closed
ericoloewe opened this issue Apr 18, 2019 · 2 comments
Closed

Improve Default Light+Theme contrast #72550

ericoloewe opened this issue Apr 18, 2019 · 2 comments
Assignees
Labels
*as-designed Described behavior is as designed themes Color theme issues

Comments

@ericoloewe
Copy link

Today is very difficult to stay more than 1 hour with the Default Light Theme because there is no "basic" contrast on it.

Contrast is important to stay more time front a screen. And the light theme is important to does not force our eyes 😄.

For more info, you can read this article: Dark or Light UI? The UX Influence.

image

image

  • VSCode Version: 1.33.1
  • OS Version: Window_NT x64 10.0.18362

Steps to Reproduce:

  1. Open VSCode
  2. File > Preferences > Color Theme
  3. Choose `Light + (default light)

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the themes Color theme issues label Apr 18, 2019
@aeschli aeschli assigned miguelsolorio and unassigned aeschli Apr 23, 2019
@Xarkam
Copy link

Xarkam commented Sep 12, 2019

Hello,

I am a Visual Studio Code and Visual Studio 2019 user.

For my visual comfort in high brightness, I decided to use the white theme in Visual Studio Code.

Activating it, I immediately noticed that the white theme lacks contrast on some colors.

Here are two images, the first comes from Visual Studio Code and the second from Visual Studio 2019.
Visual Studio Code
VisualStudioCode
Visual Studio 2019
VisualStidio2019

As we can see, in Visual Studio the contrast is better.
Note also that the font is finer in Visual Studio Code than Visual Studio. I think it's due to Electron because both software are configured identically.

The increase in font-weigth on a normal screen comes back to having bold.

Would it not be possible to review the contrast of this theme?

@miguelsolorio
Copy link
Contributor

Thanks for the feedback. While our default themes may not meet your expectations for contrast, there are several other themes available in the marketplace that you can choose from as well. With that being said, I'll be closing this issue as as-deigned.

@miguelsolorio miguelsolorio added the *as-designed Described behavior is as designed label Oct 8, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed themes Color theme issues
Projects
None yet
Development

No branches or pull requests

4 participants