Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No input box to create new file in Explorer #68691

Closed
alexdima opened this issue Feb 14, 2019 · 5 comments
Closed

No input box to create new file in Explorer #68691

alexdima opened this issue Feb 14, 2019 · 5 comments
Assignees
@joaomoreno @isidorn
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues release-notes Release notes issues verified Verification succeeded
Milestone
February 2019

Comments

@alexdima
Copy link
Member

  • Open a file like lua/language-cofiguration.json
  • Reload the workbench
  • Try to create a file in the root by collapsing all and clicking new file

kapture 2019-02-14 at 10 29 54
@frobinsonj
Copy link
Contributor

frobinsonj commented Feb 14, 2019 •
edited

The input box is at the layer of the focused file/folder. When you collapse all, it keeps focus on files and folders.

ezgif-1-3e9d6c437688

@bpasero bpasero assigned isidorn and unassigned bpasero Feb 18, 2019
@isidorn isidorn mentioned this issue Feb 18, 2019
Closed
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Feb 18, 2019
@isidorn isidorn added this to the February 2019 milestone Feb 18, 2019
@williamparry
Copy link

Is CollapseAction deprecated in favour of CollapseAction2?

@isidorn isidorn mentioned this issue Feb 20, 2019
Closed
@roa-nyx
Copy link

roa-nyx commented Feb 21, 2019

Hello, sorry if this is a bit off-topic but my issue #68126 was closed as a duplicate of this one, and I wasn't told if it was because the underlying issue was determined to be related? But I experienced entirely different behaviour then what is being called out here I think.

Can anyone have a look?

@isidorn
Copy link
Contributor

isidorn commented Feb 25, 2019

The issue here is that the tree keps the item focused even when it is collapsed. Which makes sense.
However here we need to resolveTo to the focued item. For that we need tree api similar to what is needed for #68627

@isidorn
Copy link
Contributor

isidorn commented Feb 26, 2019

Fixed by @joaomoreno

@isidorn isidorn closed this as completed Feb 26, 2019
@octref octref added the verified Verification succeeded label Feb 26, 2019
@isidorn isidorn added the release-notes Release notes issues label Mar 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues release-notes Release notes issues verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
8 participants
@joaomoreno @williamparry @bpasero @isidorn @octref @alexdima @roa-nyx @frobinsonj