Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listener leak at renderReplaceInput() #67385

Closed
bpasero opened this issue Jan 29, 2019 · 3 comments
Closed

Listener leak at renderReplaceInput() #67385

bpasero opened this issue Jan 29, 2019 · 3 comments
Assignees
@roblourens
Labels
debt Code quality issues

Comments

@bpasero
Copy link
Member

bpasero commented Jan 29, 2019

I found this in insiders, not sure how to reproduce, but I am puzzled why the replace input needs to be renderer 175 times:

6fh] potential listener LEAK detected, having 175 listeners already. MOST frequent listener (1):
e.check @ /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:79
/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:79     at s (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1866:201)
    at Object.t.attachInputBoxStyler (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1866:683)
    at t.renderReplaceInput (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5293:635)
    at t.render (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5289:867)
    at t [as constructor] (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5287:614)
    at t.create (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:229:596)
    at t.e._createInstance (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1506:215)
    at t.e.createInstance (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1505:561)
    at t.createSearchWidget (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5664:61)
    at t.create (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5657:589)
    at o.t.showComposite (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5311:137)
    at o.t.doOpenComposite (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5309:994)
    at o.t.openComposite (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5309:491)
    at o.doOpenViewlet (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5374:745)
    at o.openViewlet (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5374:49)
    at t.run (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:4938:173)
    at t.runAction (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:102:255)
    at t.run (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:102:63)
    at t.onClick (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:919:105)
    at Immediate._onImmediate (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:918:592)
    at runCallback (timers.js:696:18)
    at tryOnImmediate (timers.js:667:5)
    at processImmediate (timers.js:649:5)
@roblourens
Copy link
Member

Are viewlets ever disposed and recreated in normal usage? Did you toggle the search view from panel -> sidebar 175 times?

@bpasero
Copy link
Member Author

bpasero commented Jan 30, 2019 •
edited

@roblourens no they should not. I ran with grid layout enabled though

@roblourens roblourens added the debt Code quality issues label Mar 23, 2019
@roblourens roblourens added this to the April 2019 milestone Mar 23, 2019
@roblourens roblourens modified the milestones: April 2019, May 2019 Apr 23, 2019
@roblourens
Copy link
Member

I haven't been able to repro this. I think that exact stack only showed up once though?

MOST frequent listener (1)

@roblourens roblourens removed this from the May 2019 milestone May 23, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
debt Code quality issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblourens @bpasero