Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for a Breakpoint to be Enabled when breakpoints are deactivated #65394

Closed
JohanssonDaniel opened this issue Dec 19, 2018 · 4 comments
Closed
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@JohanssonDaniel
Copy link

  • VSCode Version: 1.31.0-insider (user setup)
  • OS Version: Windows_NT x64 10.0.17134

Steps to Reproduce:

  1. Create a breakpoint
  2. Deactivate all breakpoints in the debug view
  3. Try to enable one breakpoint
  4. The context menu shows Disable Breakpoint
  5. Clicking this option correctly switches it to Enable Breakpoint. However, since breakpoints are deactivated, the breakpoint is still not used.

Expected Behavior

The context menu shows Enable Breakpoint which would allow for a quick way to disable all breakpoints except one.

Does this issue occur when all extensions are disabled?: Yes

@JohanssonDaniel
Copy link
Author

I have been looking to try to solve this myself, however, the main problem seems to be that the debug view deactivates all breakpoints instead of disabling them. If I could continue to work on this, I think I need to know more about the main reason as to why both deactivating and disabling is used.

@isidorn isidorn added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Dec 19, 2018
@isidorn isidorn added this to the Backlog milestone Dec 19, 2018
@isidorn
Copy link
Contributor

isidorn commented Dec 19, 2018

Leaving this open as a feature request for now.
Not convinced we need it.
I would prefer that enabling any breakpoint activates all breakpoints, and as that I would treat this as a bug.
Chrome dev tools behaves just like that for example

@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Oct 8, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 8, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

2 participants