Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should escape be consumed by the integrated terminal? #6455

Closed
Tyriar opened this issue May 18, 2016 · 3 comments
Closed

Should escape be consumed by the integrated terminal? #6455

Tyriar opened this issue May 18, 2016 · 3 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues ux User experience issues verified Verification succeeded
Milestone
June 13th Stable ...

Comments

@Tyriar
Copy link
Member

Tyriar commented May 18, 2016

Integrated terminal master issue: #143

Open question: Currently pressing esc will hide the terminal, this can be a problem for some terminal programs, for example vim. Perhaps this should be configurable?
@Tyriar Tyriar added *question Issue represents a question, should be posted to StackOverflow (VS Code) ux User experience issues terminal Integrated terminal issues labels May 18, 2016
@Tyriar Tyriar self-assigned this May 18, 2016
This was referenced May 18, 2016
Closed
Closed
Closed
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed *question Issue represents a question, should be posted to StackOverflow (VS Code) labels May 24, 2016
@Tyriar Tyriar added this to the June 2016 milestone May 24, 2016
@joaomoreno
Copy link
Member

joaomoreno commented May 25, 2016 •
edited

Thinking about desktop terminals, such as iTerm, I can only close them via a global shortcut, an X button or running exit in the shell. Escape should not bubble outside to the workbench.

@Tyriar Tyriar closed this as completed in 20f73da May 31, 2016
This was referenced Jun 1, 2016
Closed
Closed
Closed
Closed
@Tyriar Tyriar added the candidate Issue identified as probable candidate for fixing in the next release label Jun 13, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Jun 13, 2016

Marked as candidate as it's a very simple change that's been reported a bunch of times.

@Tyriar Tyriar reopened this Jun 13, 2016
@Tyriar Tyriar closed this as completed Jun 13, 2016
Tyriar added a commit that referenced this issue Jun 13, 2016
@Tyriar
Make terminal consume escape key
3500c2d 
Fixes #6455
@Tyriar
Copy link
Member Author

Tyriar commented Jun 13, 2016

Cherry picked to release/1.2

@kieferrm kieferrm added the verified Verification succeeded label Jun 14, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues ux User experience issues verified Verification succeeded
Projects
None yet
Milestone
June 13th Stable Recovery
Development

No branches or pull requests
3 participants
@joaomoreno @Tyriar @kieferrm