Cannot split complete terminal created by task

[mjbvz]

Issue Type: Bug

Steps

1. With a tasks.json:

{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "ExitWithCode",
            "type": "shell",
            "command": "exit 4",
            "presentation": {
                "echo": true,
                "reveal": "silent",
                "focus": false,
                "panel": "shared",
                "showReuseMessage": true,
                "clear": false
            }
        }
    ]
}

1. Run the task.
2. This should open the intergrated terminal with the message Terminal will be reused by tasks, press any key to close it. at the bottom
3. Now click on the split terminal button

Bug
Button has no effect. No errors in developer console.

You can split the terminal for tasks that are still running.

VS Code version: Code - Insiders 1.29.0-insider (97ad72a, 2018-10-31T06:11:22.318Z)
OS version: Darwin x64 18.0.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Load (avg)	3, 3, 3
Memory (System)	16.00GB (0.30GB free)
Process Argv	-psn_0_50495525
Screen Reader	no
VM	22%

[Tyriar]

Splitting works on tasks that are active so this must be related to terminals that don't have a process (maybe just those that exit immediately?). FYI @alexr00

[kevinra]

I'd like to confirm I have the same bug on VS Cod 1.29.0, Mac OS Mojave.
I can't split the terminal used for building my C++ code. The last message of the terminal is:
"Terminal will be reused by tasks, press any key to close it." I can reuse the terminal as long as I don't press any key.

[johanforssell]

I'm not getting any terminal split since I update to 1.29.1 (Linux).

[Tyriar]

@johanforssell that's as designed, not sure why you're not getting the message though:

[Tyriar]

This works now.