Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS native tabs: duplicate actions for tabs management showing up #57421

Closed
jrieken opened this issue Aug 28, 2018 · 3 comments · Fixed by #57518 or #59793
Closed

macOS native tabs: duplicate actions for tabs management showing up #57421

jrieken opened this issue Aug 28, 2018 · 3 comments · Fixed by #57518 or #59793
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
October 2018

Comments

@jrieken
Copy link
Member

jrieken commented Aug 28, 2018

related to #25919

  • enabled native window tabs
  • restart vs code (with just a single window)
  • the window menu shows most tab specific action twice (once with managed enablement state and once without)

screen shot 2018-08-28 at 15 43 20
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Aug 28, 2018
@bpasero bpasero added this to the August 2018 milestone Aug 28, 2018
bpasero added a commit that referenced this issue Aug 29, 2018
@bpasero
try to fix #57421
2b20e65
@bpasero
Copy link
Member

bpasero commented Aug 29, 2018 •
edited

Wtf, I cannot reproduce running out of sources, but both in stable and insiders.

@jrieken
Copy link
Member Author

jrieken commented Aug 29, 2018

🤯

@bpasero bpasero mentioned this issue Aug 29, 2018
Merged
bpasero added a commit that referenced this issue Aug 29, 2018
@bpasero
Use roles for native tab menu items (#57518)
c1d5d09 
* try to fix #57421

* remove native tab items

* another try
@jrieken jrieken added the verified Verification succeeded label Aug 30, 2018
@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron and removed verified Verification succeeded labels Sep 25, 2018
@bpasero bpasero removed this from the August 2018 milestone Sep 25, 2018
@bpasero
Copy link
Member

bpasero commented Sep 25, 2018 •
edited

I am seeing this again for a reason I do not know. Looks like an electron issue to me that I cannot workaround. Seems unrelated to my macOS Mojave update, Isidor also sees it on 10.13.

image

@bpasero bpasero reopened this Sep 25, 2018
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug labels Sep 25, 2018
@bpasero bpasero changed the title Broken Window menu with Sierra tabs macOS native tabs: duplicate actions for tabs management showing up Sep 25, 2018
@agurod42 agurod42 mentioned this issue Oct 1, 2018
Merged
@bpasero bpasero added this to the October 2018 milestone Oct 2, 2018
@bpasero bpasero removed electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Oct 2, 2018
@komealy komealy mentioned this issue Oct 29, 2018
Closed
@mjbvz mjbvz added the verified Verification succeeded label Oct 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
October 2018
3 participants
@bpasero @jrieken @mjbvz