Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue reporter: use custom dropdown on Windows #56978

Closed
bpasero opened this issue Aug 22, 2018 · 3 comments
Closed

Issue reporter: use custom dropdown on Windows #56978

bpasero opened this issue Aug 22, 2018 · 3 comments
Assignees
Labels
debt Code quality issues issue-reporter Issue reporter widget issues *out-of-scope Posted issue is not in scope of VS Code

Comments

@bpasero
Copy link
Member

bpasero commented Aug 22, 2018

I suggest to use our custom dropdown on Windows for the issue reporter to match the style of dropdowns we have in the workbench:

image

@bpasero bpasero added the issue-reporter Issue reporter widget issues label Aug 22, 2018
@RMacfarlane RMacfarlane added the feature-request Request for new features or functionality label Sep 18, 2018
@cleidigh
Copy link
Contributor

cleidigh commented Oct 9, 2018

@RMacfarlane
If you need anything on this, let me know.
I can also pick this up if you wish.

@RMacfarlane RMacfarlane added debt Code quality issues and removed feature-request Request for new features or functionality labels Oct 7, 2019
@JacksonKearl JacksonKearl added the *out-of-scope Posted issue is not in scope of VS Code label Oct 8, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 8, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 8, 2019
@JacksonKearl
Copy link
Contributor

@bpasero I started looking into this and found that using the custom SelectBox widget would introduce a fairly large amount of code bloat:

In short: the Issue Reporter window doesn't have some of the services needed by SelectBox, particularly ContextViewService, which requires a LayoutService. While that can be shimmed to work, we're still left without a styling service. Currently the styles are transferred as query params to the new window, and as the SelectBox builds upon the List widget, it requires a ton of different color keys, which then need to be serialized and deserialized, and all in all it's just a big can of worms.

At that point I consulted with Rachel and we decided this would be more bloat than its worth, additionally, I consulted with @eamodio and the current Windows dropdowns seem stylistically and functionally fine. Unless you feel differently I'm going to close as out of scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues issue-reporter Issue reporter widget issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

4 participants