Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workbench.editor.openPositioning pendant for tab groups #56142

Closed
EnCey opened this issue Aug 10, 2018 · 3 comments
Closed

Create workbench.editor.openPositioning pendant for tab groups #56142

EnCey opened this issue Aug 10, 2018 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality markdown Markdown support issues

Comments

@EnCey
Copy link

EnCey commented Aug 10, 2018

Steps to reproduce

  1. Open a markdown file via explorer (ctrl+shift+e) and then its preview (ctrl+k, v)
  2. Open a second markdown file via explorer
    Result: markdown file opened in a new tab in the left tab group, its preview replaced the previous one in the right tab group
  3. Open a third markdown file via explorer
    Result: markdown file opens in the 2nd tab group next to the preview and spawns a 3rd tab group

Expected behavior

Markdown files should always be opened in the left tab group and their preview in the 2nd tab group.
This behavior is independent of other tab settings (open markdown file as preview, do not use tabs at all, etc.)

The problem

It seems that after step 2) the preview tab in the 2nd tab group has focus. This is why in step 3), the markdown file is opened in the 2nd tab group.

This process can be repeated indefinitely. After step 3), the preview in tab group 3 has focus. If another markdown file is opened, it will open in the 3rd tab group and spawn a 4th group.

Why this matters

When editing markdown files in a folder, you often have to switch between files.
I cannot fathom a scenario where someone would want a new markdown file to be opened next to a preview tab, effectively hiding the preview and displaying the 2 markdown files side-by-side, plus showing a preview of the 2nd in a 3rd tab group.

Possible solution

Create a setting similar to workbench.editor.openPositioning, only that it controls which tab group is used when opening new files. I.e. when setting this to first it would solve the problem described here.

@vscodebot vscodebot bot added the markdown Markdown support issues label Aug 10, 2018
@EnCey
Copy link
Author

EnCey commented Aug 10, 2018

This is perhaps related to, but not a duplicate of #19339.
The issue here is simply that you cannot quickly open a bunch of markdown files via the explorer view without ending up with 3+ tab groups.

@mjbvz
Copy link
Contributor

mjbvz commented Jul 7, 2020

Closing due to lack of further feedback since this was opened 2 years ago

@mjbvz mjbvz closed this as completed Jul 7, 2020
@mjbvz mjbvz added the feature-request Request for new features or functionality label Jul 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality markdown Markdown support issues
Projects
None yet
Development

No branches or pull requests

2 participants