Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch pane does not use evaluateName when executing "Copy Value" #54853

Closed
DanTup opened this issue Jul 23, 2018 · 3 comments
Closed

Watch pane does not use evaluateName when executing "Copy Value" #54853

DanTup opened this issue Jul 23, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@DanTup
Copy link
Contributor

DanTup commented Jul 23, 2018

I've had a bug raised where values copied (using Copy Value) from the Watch pane are truncated. I investigated, and it seems like there is a difference in behaviour between the Variables and Watch panes. I'm examining an array with a single long string in it:

screen shot 2018-07-23 at 9 42 59 am

In both the scopesRequest and the evaluateRequest I return a variablesReference for the array. In the variablesRequest they both return the same data, which is the following (an array of Variable):

[
	{
		"evaluateName": "longStrings[0]",
		"indexedVariables": null,
		"name": "[0]",
		"type": "String (_OneByteString)",
		"value": "\"This is a long string that is 300 characters! This is a long string that is 300 characters! This is a long string that is 300 ch…\"",
		"variablesReference": 0
	}
]

This has a truncated string for display, and an evaluateName that will give the full string. However it seems that when I choose Copy Value from the Variables window the expression gets evaluated, but choosing Copy Value from the Watch window just copies the truncated value into the clipboard.

screen shot 2018-07-23 at 9 47 44 am

(@isidorn does this seem like a bug, or are they intended to work differently?)

@isidorn
Copy link
Contributor

isidorn commented Jul 23, 2018

You are right, this is an issue and I can push a fix for it by passing variable instead of variable.value here

However this seems to uncover another bug from node-debug. Which is that the evaluateName for variables in watch window are bogus. @weinand @roblourens can you please investigate? Or if you prefer i can push a fix for this issue which will uncover the other issue

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach labels Jul 23, 2018
roblourens added a commit to microsoft/vscode-chrome-debug-core that referenced this issue Jul 23, 2018
@roblourens
Copy link
Member

I pushed a fix for the evaluateName issue.

@isidorn
Copy link
Contributor

isidorn commented Jul 24, 2018

@roblourens great than I will push a fix for this!

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Jul 24, 2018
@isidorn isidorn added this to the July 2018 milestone Jul 24, 2018
@JacksonKearl JacksonKearl added the verified Verification succeeded label Aug 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants