Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbench.action.terminal.rename does not return focus to element that was focused when command was issued #53294

Closed
percygrunwald opened this issue Jun 29, 2018 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster terminal Integrated terminal issues

Comments

@percygrunwald
Copy link

  • VSCode Version: Version 1.24.1 (1.24.1)
  • OS Version: Mac OS 10.13.5

Current Behavior:

  • After confirming or cancelling the "Enter terminal name" dialogue box, the focus is always returned to the "first editor", regardless of where the focus was when the workbench.action.terminal.rename command was issued.

Expected Behavior:

  • After confirming or cancelling the "Enter terminal name" dialogue box, the focus should return to wherever the focus was when the workbench.action.terminal.rename command was issued.

Steps to Reproduce:

  1. Focus on the terminal (terminalFocus == true)
  2. Issue workbench.action.terminal.rename command
  3. Input new name for terminal session and press "enter" to accept
  4. Dialogue box closes, but focus is now on the first editor, rather than the terminal

or

  1. Focus on the terminal (terminalFocus == true)
  2. Issue workbench.action.terminal.rename command
  3. Press "escape" to cancel
  4. Dialogue box closes, but focus is now on the first editor, rather than the terminal

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Jun 29, 2018
@vscodebot
Copy link

vscodebot bot commented Jun 29, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2018

@bpasero I think we've spoken about returning focus after a command is canceled before, can't seem to find the issue though. Do you know which one it was?

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Jun 29, 2018
@bpasero
Copy link
Member

bpasero commented Jun 30, 2018

@Tyriar #44722

@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 30, 2018
@vscodebot
Copy link

vscodebot bot commented Jun 30, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Jun 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

3 participants