Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum should be defined before use #49852

Closed
kendrickw opened this issue May 14, 2018 · 1 comment
Closed

Enum should be defined before use #49852

kendrickw opened this issue May 14, 2018 · 1 comment
Assignees
@rebornix
Labels
debt Code quality issues
Milestone
June 2018

Comments

@kendrickw
Copy link

The enum NodeColor is used before definition in rbTreeBase.ts:

https://github.com/Microsoft/vscode/blob/95dfbe441038ed4cae61aae56c07c1a1f75b1b27/src/vs/editor/common/model/pieceTreeTextBuffer/rbTreeBase.ts#L81

https://github.com/Microsoft/vscode/blob/95dfbe441038ed4cae61aae56c07c1a1f75b1b27/src/vs/editor/common/model/pieceTreeTextBuffer/rbTreeBase.ts#L87

This problem doesn't affect VScode, but it does cause problem when creating a single UMD bundle with @timkendrick/monaco-editor

Not sure why typescript isn't flagging this as an error. But this issue in TypeScript repo seem to suggest that this should already been disallowed.
@vscodebot vscodebot bot added the typescript Typescript support issues label May 14, 2018
@mjbvz mjbvz assigned rebornix and unassigned mjbvz May 14, 2018
@mjbvz mjbvz removed the typescript Typescript support issues label May 14, 2018
@rebornix rebornix added this to the June 2018 milestone Jun 6, 2018
@rebornix rebornix added the debt Code quality issues label Jun 6, 2018
@rebornix
Copy link
Member

rebornix commented Jun 6, 2018

@kendrickw nice catch!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
debt Code quality issues
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
3 participants
@rebornix @kendrickw @mjbvz