Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to that the Debug View is shown automatically when the debugger breaks #49677

Closed
escamoteur opened this issue May 11, 2018 · 3 comments · Fixed by #49936
Closed
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@escamoteur
Copy link

Currently if I start my App with another View than Debug View open and the debugger breaks because of a break point or an exception I have to manually switch to the debug view.

It would be incredible if I could set an option to display the debug view in that cases automatically

Thanks for your great Work!

@isidorn
Copy link
Contributor

isidorn commented May 11, 2018

This is a fair feature request. If we get more users asksing for this we would be willing to accept a PR that fixes this.
Thanks

@isidorn isidorn removed their assignment May 11, 2018
@isidorn isidorn added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels May 11, 2018
@isidorn isidorn added this to the Backlog milestone May 11, 2018
@escamoteur
Copy link
Author

@isidorn Why only as PR? I guess it will be only a very small change but I'm not a Typescript dev and have no idea about the internal structure of VS Code. For your team this should be a quick fix.

@isidorn
Copy link
Contributor

isidorn commented May 15, 2018

Because we encourage people to be invovled in our open source project
https://github.com/Microsoft/vscode/wiki/How-to-Contribute

Code pointer https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/electron-browser/debugService.ts#L275

The following setting should be updated to also cover this case
debug.openDebug to also have the following option "openOnDebugBreak"

No typescript knowledge is needed for this PR

fyi @weinand

@isidorn isidorn added help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels May 15, 2018
@isidorn isidorn self-assigned this May 16, 2018
@isidorn isidorn modified the milestones: Backlog, May 2018 May 16, 2018
@isidorn isidorn added the verification-needed Verification of issue is requested label May 29, 2018
@weinand weinand added the verified Verification succeeded label May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants