Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify activeParameter in SignatureHelp #49528

Closed
dbaeumer opened this issue May 9, 2018 · 1 comment
Closed

Clarify activeParameter in SignatureHelp #49528

dbaeumer opened this issue May 9, 2018 · 1 comment
Assignees
@jrieken
Labels
api debt Code quality issues editor-parameter-hints Function, method and class parameter hint widget

Comments

@dbaeumer
Copy link
Member

dbaeumer commented May 9, 2018

activeParameter is currently speced to be only valid on the active signature. However we use it as well if the users scrolls through signature options to highlight the active parameter. We should adjust the doc accordingly and we might want to consider whether signartures that have less number of parameters than the active parameter should be filtered.
@dbaeumer dbaeumer added the api label May 9, 2018
@jrieken jrieken added debt Code quality issues editor-symbols definitions, declarations, references labels May 9, 2018
@jrieken jrieken added editor-parameter-hints Function, method and class parameter hint widget and removed editor-symbols definitions, declarations, references labels Sep 17, 2018
@jrieken
Copy link
Member

jrieken commented May 1, 2020

I believe we have all of that now, esp the user selected value is passed on to extensions now

@jrieken jrieken closed this as completed May 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
api debt Code quality issues editor-parameter-hints Function, method and class parameter hint widget
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrieken @dbaeumer