Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic insert or delete ending brackets #48121

Closed
pawelzwronek opened this issue Apr 18, 2018 · 3 comments
Closed

Automatic insert or delete ending brackets #48121

pawelzwronek opened this issue Apr 18, 2018 · 3 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-autoclosing Editor automatic closing of parens / brackets / etc. feature-request Request for new features or functionality
Milestone

Comments

@pawelzwronek
Copy link

  • VSCode Version: 1.22.2
  • OS Version: Win10

Steps to Reproduce:

  1. Write a line with missing some brackets at the end: let a = max(0, 2 * (b+1|) with cursor placed before last ending bracket, as shown with |

Feature request:
After pressing ) once insert or delete as many ')' as needed so the error [ts] ')' expected. will disappear.

Today's behavior:
Now I have to first press as many ) so the cursor is placed at the end, skipping over the existing brackets(it's quite annoying), and then manually repair missing brackets 😢

@vscodebot
Copy link

vscodebot bot commented Apr 18, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added editor editor-bracket-matching Editor brace matching labels Apr 18, 2018
@alexdima alexdima added editor-autoclosing Editor automatic closing of parens / brackets / etc. and removed editor editor-bracket-matching Editor brace matching labels Apr 18, 2018
@alexdima
Copy link
Member

Similar: #16915

@alexdima alexdima added the feature-request Request for new features or functionality label Apr 18, 2018
@alexdima alexdima added this to the Backlog milestone Apr 18, 2018
@alexdima alexdima removed their assignment Apr 18, 2018
@rebornix
Copy link
Member

rebornix commented Sep 5, 2018

Shared the same root cause as #37315 and #6841, let's track this issue in #6841 . We don't check whether a open or close bracket/paren is already paired or not at this moment.

@rebornix rebornix closed this as completed Sep 5, 2018
@rebornix rebornix added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-autoclosing Editor automatic closing of parens / brackets / etc. feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants