Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run organise imports on save #46678

Closed
jrieken opened this issue Mar 27, 2018 · 4 comments
Closed

Run organise imports on save #46678

jrieken opened this issue Mar 27, 2018 · 4 comments
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality javascript JavaScript support issues on-testplan typescript Typescript support issues
Milestone
April 2018

Comments

@jrieken
Copy link
Member

jrieken commented Mar 27, 2018

re #46589

It should be possible to configure organise import (read code actions in general) so that they run on save.
@mjbvz mjbvz added this to the April 2018 milestone Mar 27, 2018
@mjbvz mjbvz added feature-request Request for new features or functionality typescript Typescript support issues javascript JavaScript support issues labels Mar 27, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Mar 27, 2018

Yes, currently the feature is not reliable enough for me to feel confident triggering it on save but next iteration we should hook this up

@mjbvz
Copy link
Contributor

mjbvz commented Apr 16, 2018

Depends on #42092

@uloco
Copy link

uloco commented Apr 17, 2018

A better option imho would be to make it configurable to be run when formatting, rather than on save. At least I would expect auto format to handle such things, rather a file save...

@kieferrm kieferrm mentioned this issue Apr 17, 2018
Closed
45 tasks
@mjbvz
Copy link
Contributor

mjbvz commented Apr 23, 2018

Enabled by #48086,

	"editor.codeActionsOnSave": {
		"source.organizeImports": true
	}

This is not enable by default currently

@mjbvz mjbvz closed this as completed Apr 23, 2018
@mjbvz mjbvz mentioned this issue Apr 23, 2018
Closed
2 tasks
@DanTup DanTup mentioned this issue May 2, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality javascript JavaScript support issues on-testplan typescript Typescript support issues
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
3 participants
@jrieken @uloco @mjbvz