Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folding] finish language-aware folding #45981

Closed
aeschli opened this issue Mar 16, 2018 · 5 comments
Closed

[folding] finish language-aware folding #45981

aeschli opened this issue Mar 16, 2018 · 5 comments
Assignees
Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality on-testplan
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Mar 16, 2018

Finish the work on the HTML and JSON folding providers:

  • handle cancellation
  • limit the number of ranges transmitted
  • support multi-line comments
  • stable ranges while editing

Investigate:

@vscodebot vscodebot bot added editor editor-contrib Editor collection of extras labels Mar 16, 2018
@aeschli aeschli changed the title Finish language-aware folding [folding] finish language-aware folding Mar 16, 2018
@aeschli aeschli self-assigned this Mar 16, 2018
@aeschli aeschli added this to the March 2018 milestone Mar 16, 2018
@aeschli aeschli added feature-request Request for new features or functionality editor-folding Editor code folding issues and removed editor-contrib Editor collection of extras editor labels Mar 16, 2018
@aeschli aeschli closed this as completed Mar 27, 2018
@DanTup
Copy link
Contributor

DanTup commented Apr 3, 2018

@aeschli I noticed this is in the release notes for March but currently only a proposed API - is this planned to ship as a stable API in this release? (If so, will it be moved to vscode.d.ts in advance? dev is simpler when things aren't proposed 😁)

@aeschli
Copy link
Contributor Author

aeschli commented Apr 3, 2018

Yes, this is planned to go to vscode.d.ts once we have enough confidence and reviews.

@DanTup
Copy link
Contributor

DanTup commented Apr 7, 2018

@aeschli I'm slightly confused - the top of the release notes say there's language-aware folding, but further down it says the API is proposed. It's unclear whether I can actually implement and ship this yet?

@aeschli
Copy link
Contributor Author

aeschli commented Apr 8, 2018

Language aware folding is now in use by CSS, HTML, JSON, TS, JS, Markdown.
These are the built-in extensions from VSCode. Regular extensions can compile against new proposed APIs, but can not use them in published versions. It would be great if you can try them and give feedback. That gives us the chance to still make modifications.
Once the APIs will become permament in the next release you can also publish your support.

@DanTup
Copy link
Contributor

DanTup commented Apr 8, 2018

These are the built-in extensions from VSCode

Ah, didn't realise they could use them, all makes sense now!

I was trying to figure out if I could put them in my release towards the end of the month but I guess it'll need to wait. If I get chance after completing the stuff for this release I'll wire this up on a branch and ensure it all works for us. Thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

2 participants