Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript auto imports should be absolute in our repo #43575

Closed
joaomoreno opened this issue Feb 13, 2018 · 1 comment
Closed

Typescript auto imports should be absolute in our repo #43575

joaomoreno opened this issue Feb 13, 2018 · 1 comment
Assignees
@mjbvz
Labels
engineering VS Code - Build / issue tracking / etc. formatting Source formatter issues typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2018

Comments

@joaomoreno
Copy link
Member

Not sure about other repositories, but we have the convention of always using absolute imports. Relative ones even cause lint issues:

image
@mjbvz
Copy link
Contributor

mjbvz commented Feb 13, 2018

I think the current strategy chooses whichever path is shortest. We're tracking allowing this to be explicitly configured with microsoft/TypeScript#21860 as part of microsoft/TypeScript#20619

@mjbvz mjbvz added typescript Typescript support issues formatting Source formatter issues labels Feb 13, 2018
@mjbvz mjbvz mentioned this issue Mar 20, 2018
Closed
@about-code about-code mentioned this issue Apr 9, 2018
Closed
@mjbvz mjbvz added the engineering VS Code - Build / issue tracking / etc. label May 8, 2018
@mjbvz mjbvz added this to the May 2018 milestone May 8, 2018
@mjbvz mjbvz closed this as completed in 84d0237 May 8, 2018
@mjbvz mjbvz added the verification-needed Verification of issue is requested label May 25, 2018
@isidorn isidorn added the verified Verification succeeded label May 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
engineering VS Code - Build / issue tracking / etc. formatting Source formatter issues typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
3 participants
@joaomoreno @isidorn @mjbvz