Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal in explorer should pre-select all or none of the selected items #42576

Closed
ramya-rao-a opened this issue Jan 30, 2018 · 4 comments
Closed
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

Testing #41473

  • Multi select 2 files that are siblings
  • Choose Reveal in Explorer
  • The Explorer opens with only one of the 2 items pre-selected

Either neither should be selected, or both should be selected. Why choose the one that is alphabetically higher than the other

@ramya-rao-a ramya-rao-a changed the title Reveal in explorer should pre-select all selected items Reveal in explorer should pre-select all or none of the selected items Jan 30, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Jan 30, 2018

Ran into this as well. Another idea: open a separate window for each item, just like we do for items in different folders (not sure about this however, could be obnoxious)

@isidorn
Copy link
Contributor

isidorn commented Jan 31, 2018

@mjbvz I think that would be too spamy
@ramya-rao-a this is a fair feature request that both should be selected

Code pointer https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/electron-browser/fileCommands.ts#L390
Basically the windowService should also have showItemsInFolder

@isidorn isidorn added feature-request Request for new features or functionality file-explorer Explorer widget issues labels Jan 31, 2018
@isidorn isidorn added this to the Backlog milestone Jan 31, 2018
@isidorn isidorn removed their assignment Jan 31, 2018
@oriash93
Copy link
Contributor

oriash93 commented Mar 3, 2018

I'm not sure is that simple.

https://github.com/Microsoft/vscode/blob/master/src/vs/platform/windows/electron-main/windowsService.ts#L424

As you can see, windowService's showItemInFolder method, calls showItemInFolder method from Electron's Shell class (Docs here), which says:
"Show the given file in a file manager. If possible, select the file."
It can't support more than one file.

@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Sep 21, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 21, 2018

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

4 participants