Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for all the VS Code file associations, looks weird. #38063

Closed
ZenMittal opened this issue Nov 10, 2017 · 7 comments
Closed

Icons for all the VS Code file associations, looks weird. #38063

ZenMittal opened this issue Nov 10, 2017 · 7 comments
Labels
*as-designed Described behavior is as designed icon-brand VS Code brand icon issues

Comments

@ZenMittal
Copy link

  • VSCode Version: 1.18.0
  • OS Version: Windows 10

Image of some files

I moved from sublime to VS Code today. But when I set VS Code as the default app for opening any programming files, it creates this weird icon Instead of some cool icon like that of sublime text.

Any help?

@agauniyal
Copy link

so you want a new icon? preferably orange colored? 😆

@ZenMittal
Copy link
Author

haha nope. But VS code's icon embedded inside of a file icon is really offputting. Not sure it's on my end or same for everyone.

@bpasero
Copy link
Member

bpasero commented Nov 11, 2017

We are not planning to change the icon, please see https://code.visualstudio.com/blogs/2017/10/24/theicon

@bpasero bpasero closed this as completed Nov 11, 2017
@bpasero bpasero added *as-designed Described behavior is as designed icon-brand VS Code brand icon issues labels Nov 11, 2017
@bpasero bpasero removed their assignment Nov 11, 2017
@ZenMittal
Copy link
Author

I wasn't talking about the main icon at all. I'm talking about the main icon not appearing by itself but embedded inside a file icon.

real issue

Green is okay. Red is the issue.

@ketozhang
Copy link

ketozhang commented Nov 15, 2017

@bpasero I think you read the post wrong. Please re-open or link duplicates

I agree with @ZenMittal. While the icon itself looks great as a shortcut, the file association icon (which is has a different dir) is bad because it is surrounded by a piece of paper (background is the Windows' default for no-extension).

I was able to fix it by changing the registry however it's a hassle to do it for ALL file extensions (must do it one file type by one unless you got a script).

DISCLAIMER: THIS IS NOT HOW VSCODE ICONS LOOKS RIGHT NOW

Small Icon

Small Icon

Large Icon

Large Icon

@bpasero
Copy link
Member

bpasero commented Nov 15, 2017

@ZenMittal @ketozhang sorry for not being clear, all of the icons we use in our icon update are meant to stay like that, so the file association icon is meant to be like that showing a document.

@ketozhang
Copy link

@bpasero
☹️ While it is a minor visual request I guess you guys would only change it if we get another EA-downvote thread like #35783

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed icon-brand VS Code brand icon issues
Projects
None yet
Development

No branches or pull requests

4 participants