Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tasks -> Configure Default Build Task does not preserve comments #37138

Closed
egamma opened this issue Oct 30, 2017 · 1 comment
Closed

Tasks -> Configure Default Build Task does not preserve comments #37138

egamma opened this issue Oct 30, 2017 · 1 comment
Assignees
@dbaeumer
Labels
*duplicate Issue identified as a duplicate of another issue(s) tasks Task system issues

Comments

@egamma
Copy link
Member

egamma commented Oct 30, 2017

I had some comments in my tasks.json.
After running Tasks>Configure Default Build Task these comments were removed.
@egamma egamma added the tasks Task system issues label Oct 30, 2017
@dbaeumer
Copy link
Member

dbaeumer commented Oct 30, 2017 •
edited

This is know and a problem of the settings writer that doesn't preserve all comments. The dup is here: #29453

At that time I shortly investigated in using Martin's JSON parser and doing my own setting writings but then dropped it since it is a more general problem in our settings story.

I will close as a dup. Please ping if you feel strongly about having this fixed in Task land directly.

@dbaeumer dbaeumer added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbaeumer dbaeumer

Labels
*duplicate Issue identified as a duplicate of another issue(s) tasks Task system issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@egamma @dbaeumer