Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutputChannel - remove show function #36844

Closed
ShiftySituation opened this issue Oct 24, 2017 · 11 comments
Closed

OutputChannel - remove show function #36844

ShiftySituation opened this issue Oct 24, 2017 · 11 comments
Assignees
Labels
feature-request Request for new features or functionality output Output channel system issues
Milestone

Comments

@ShiftySituation
Copy link

Feature Request

  • VSCode Version: 1.17.2
  • OS Version: Windows10

Remove the show function from OutputChannel. Reason, coders need less distractions so allowing extensions to control what I see is a huge distraction. Plus it is annoying when typing commands in the terminal and all of a sudden the output window comes into view.

@dbaeumer
Copy link
Member

In general I see why @ShiftySituation is aksing for this however removing the show function is not the right way to tackle this. Two things that I think can be improved:

  • a badge indicating that a message is there but not read
  • tracking down the cases where the output channel comes to front and is not necessary and fix those.

@isidorn assigning to you as the owner of the output channel.

@dbaeumer dbaeumer added the output Output channel system issues label Oct 25, 2017
@isidorn
Copy link
Contributor

isidorn commented Oct 25, 2017

We are exploring adding the badges to the output channel. All the infrastrucutre is there for this.
Once we have adopted this in the output channel we can look into revisting where we call show.

As for the extension we can not prevent them from doing this, though I understand your concern.
fyi @jrieken

@isidorn isidorn added the feature-request Request for new features or functionality label Oct 25, 2017
@isidorn isidorn added this to the Backlog milestone Oct 25, 2017
@jrieken
Copy link
Member

jrieken commented Oct 25, 2017

No way we can remove that function from the API but "yes" we should have this overrule-able by the user.

@isidorn
Copy link
Contributor

isidorn commented Oct 25, 2017

Let's wait and see if more people ask for it and I can add some configuration.

@lemoinem
Copy link

@isidorn Yes, people ask for it. Please refer to angular/vscode-ng-language-service#128 for example.

@ShiftySituation
Copy link
Author

ShiftySituation commented Oct 25, 2017

@jrieken Just out of curiosity, what is an example use-case that would clarify this api function as being beneficial?

@isidorn
Copy link
Contributor

isidorn commented Oct 26, 2017

@lemoinem yeah that is a problem with the angular extension and should be fixed there and not using a workaround in vscode. You could probably provide a PR to that extension to just stop calling show all the time

@paustint
Copy link

@isidorn , according to @chuckjaz from vscode-ng-language-service:

My code does not call that method at all (https://github.com/angular/vscode-ng-language-service/blob/master/client/src/extension.ts). This is call happens in the client library I am using which is provided by the vscode team.

@isidorn
Copy link
Contributor

isidorn commented Oct 30, 2017

@paustint thanks for more details, however what client library is he refering to?
Is he simply using our api and if yes what exact call does the automatic show of output?

@dbaeumer
Copy link
Member

@isidorn it is the LSP client library

@chuckjaz if the output channel is reveal or not can be control in the client library via the revealOutputChannelOn setting.

@isidorn
Copy link
Contributor

isidorn commented Nov 13, 2017

Seems like this is configurable in the client library, no action to do here on the vscode side (as far as I understand) -> closing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality output Output channel system issues
Projects
None yet
Development

No branches or pull requests

6 participants