Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy Authentification Frame shows menu bar and is glitched because of it #36751

Closed
qrybe opened this issue Oct 23, 2017 · 3 comments
Closed

Proxy Authentification Frame shows menu bar and is glitched because of it #36751

qrybe opened this issue Oct 23, 2017 · 3 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Milestone
October 2017

Comments

@qrybe
Copy link

qrybe commented Oct 23, 2017

Demo Image
When you get asked for a password, the default electron menubar occurs on top which breaks the design of the frame.

  • VSCode Version: 1.17.2
  • OS Version: Windows 10

Steps to Reproduce:

  1. set a windows proxy with authentification in the settings
  2. wait until the question asking for login credentials occurs

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the workbench label Oct 23, 2017
@bpasero bpasero assigned joaomoreno and unassigned bpasero Oct 24, 2017
@joaomoreno joaomoreno added this to the October 2017 milestone Oct 27, 2017
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Oct 27, 2017
@joaomoreno
Copy link
Member

@bpasero This could be an Electron regression.

@roblourens
Copy link
Member

@joaomoreno Where can I find a proxy that requires authentication?

@chrmarti chrmarti added the verified Verification succeeded label Nov 4, 2017
@chrmarti
Copy link
Contributor

chrmarti commented Nov 4, 2017

Verified with a local squid proxy.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
5 participants
@joaomoreno @roblourens @bpasero @chrmarti @qrybe