Inconsistent undo/redo behavior in Ctrl-F field

[obskyr]

• VSCode Version: 1.12.2
• OS Version: Windows 10

Steps to Reproduce:

1. Press Ctrl-F
2. Type something into the field
3. Select some text in the file being edited
4. Press Ctrl-F again
5. Try to undo/redo using keyboard shortcuts

Characters will be deleted and added almost at random, based on the field's state before the contents were replaced in step 4. This seems to be because the undo/redo history stores characters being entered and deleted, but the replacement of the entire field contents is not stored on the field's history stack. If it were, an undo would simply revert the Ctrl-F field to its earlier state.

Other fields may have the same problem - the basic issue here is that an operation isn't being pushed to the history stack.

[rebornix]

@obskyr I do occasionally run into this kind of issue when using the input box in Search Viewlet but I don't have a good repro. can you provide a gif to help troubleshoot?

[obskyr]

@rebornix Sure! Here you go:

In this GIF, I:

1. Type "Hello!" into the main window
2. Press Ctrl-F
3. Type "abcdefg"
4. Select the "Hello!"
5. Press Ctrl-F
6. Press Ctrl-Z a few times
7. Press Ctrl-Shift-Z a few times
8. Press Ctrl-Z a few times
9. Press Ctrl-Shift-Z a few times
10. Press Ctrl-Z until it takes me out of the search field, and from there mess about with Ctrl-Z and Ctrl-Shift-Z a bit more

Also see this related buggy behavior:

In this GIF, I:

1. Type "Hello!" into the main window
2. Select it
3. Press Ctrl-F
4. Press Ctrl-Z
5. Type lots of question marks in bewilderment as a second copy of "Hello!" appears where my cursor was in the main window (I've seen it appear in the middle of the word before, so I'm fairly certain it gets put where the cursor is/was.)

[rebornix]

@obskyr I really appreciate your gif and reproduce steps :)

[rebornix]

It's likely a browser issue as https://w3c.github.io/editing/execCommand.html#introduction is in draft and you can see weird behavior when playing Monaco Find Widget in Chromium but it's kind of good in Firefox.

[EmpireJones]

@rebornix, @alexandrudima this bug seems to still exist and is super annoying. Is there a particular upstream project which we need to forward this issue to? monaco-editor?

Also, I'd like to add that it'd be great if the find and replace fields had separate undo stacks, like Atom has. However, such support isn't useful until this issue is fixed.

[rebornix]

Now that we are using the shared history enabled input box, maybe we can improve the experience.

[sandy081]

@rebornix Can you please elaborate what improvements you are expecting with history here?

[sandy081]

Ping @rebornix ☝️

[rebornix]

@sandy081 I found that cmd+z works in a weird way now in the find input, but I'm wondering if it's managed by the history feature

• Create an untitled text editor
• CMD+F to open the find widget, type in abcdef
• Focus the editor, type in hello
• CMD+F, which will replace the find input keyword to hello
• CMD+Z multiple times (in my test 4 times), and then the find input keyword becomes hellohellohello

[sandy081]

I do not think cm+z is an history feature. Not sure who owns this. Sorry.

[amunger]

this seems to be fixed now