Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treeview multiselect is flakey #208802

Open
eamodio opened this issue Mar 26, 2024 · 4 comments · May be fixed by #211465
Open

Treeview multiselect is flakey #208802

eamodio opened this issue Mar 26, 2024 · 4 comments · May be fixed by #211465
Assignees
@joaomoreno @alexr00
Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues
Milestone
May 2024

Comments

@eamodio
Copy link
Contributor

eamodio commented Mar 26, 2024 •
edited

I've been adding multi-select support to GitLens treeview and noticed a few issues with tree views with canSelectMany enabled

Using shift-click, ctrl-click don't usually work correctly the "first" time, but seem to (usually) fix themselves on repeated attempts.

Untitled.video.mp4

In the above, I've made a quick modification to the TreeView Sample to enabled canSelectMany and just added a few more nodes to make it easier to see. And then clicked the first node, and then shift-clicked the last, and you can see that it didn't fully select all the nodes in between. But when I repeated the shift-click it fixed it.

I am not sure what causes it to work/not work sometimes and not others -- but it always seems to not work the first time, but there are other cases when it is just flakey.

/cc @alexr00
@alexr00 alexr00 self-assigned this Mar 26, 2024
@alexr00 alexr00 added this to the April 2024 milestone Mar 26, 2024
@alexr00
Copy link
Member

alexr00 commented Apr 22, 2024

I'm having trouble reproducing this issue, even on the "first" time. If you find some other way to get a good repro I'd like to take a look!

@alexr00 alexr00 modified the milestones: April 2024, Backlog Apr 22, 2024
@alexr00 alexr00 added the tree-views Extension tree view issues label Apr 22, 2024
@alexr00 alexr00 mentioned this issue Apr 25, 2024
Open
@alexr00
Copy link
Member

alexr00 commented Apr 25, 2024

Possible repro steps: https://github.com/microsoft/vscode/assets/54879025/1052625a-aff6-49fc-bb07-8d8958b976ad

@alexr00 alexr00 modified the milestones: Backlog, May 2024 Apr 25, 2024
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Apr 25, 2024
@eamodio
Copy link
Contributor Author

eamodio commented Apr 25, 2024

Reproduces easily for me

Recording.2024-04-25.113020.mp4

I'm on Windows if that matters

@alexr00
Copy link
Member

alexr00 commented Apr 26, 2024

I can repro 👍

alexr00 added a commit that referenced this issue Apr 26, 2024
@alexr00
Treeview multiselect is flakey
fa74810 
Fixes #208802
@alexr00 alexr00 linked a pull request Apr 26, 2024 that will close this issue
Open
@joaomoreno joaomoreno self-assigned this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaomoreno joaomoreno

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

Treeview multiselect is flakey microsoft/vscode
3 participants
@joaomoreno @eamodio @alexr00