Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DECSCUSR 0 should reset to the user-defined cursorStyle #211394

Open
notpeelz opened this issue Apr 25, 2024 · 1 comment
Open

DECSCUSR 0 should reset to the user-defined cursorStyle #211394

notpeelz opened this issue Apr 25, 2024 · 1 comment
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone
Backlog

Comments

@notpeelz
Copy link

notpeelz commented Apr 25, 2024 •
edited

VS Code Version: 1.88.1
OS: Linux

Steps to Reproduce:

  1. Add "terminal.integrated.cursorStyle": "line" to your settings.json
  2. Run these commands in the integrated terminal:
printf "\033[4 q" # set cursor style to an underscore
printf "\033[0 q" # this should restore the cursor to the user-defined preference
printf "\033[ q"  # (this has the same effect as "0")
# ...but instead we end up with a "block" cursor

Relevant code: https://github.com/xtermjs/xterm.js/blob/2edc65baaa50f8b99c67f3df6f8d5d93c70a69e6/src/common/InputHandler.ts#L2732-L2738

Many popular terminals implement this behavior (e.g kitty, alacritty, Windows Terminal, ...)
More info on the topic: microsoft/terminal#7379

xterm issue: xtermjs/xterm.js#3293
@meganrogge meganrogge added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream labels Apr 26, 2024
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Apr 26, 2024
@Tyriar Tyriar added this to the Backlog milestone Apr 26, 2024
@Tyriar Tyriar added help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Apr 26, 2024
@kevinc16
Copy link

kevinc16 commented May 3, 2024

Hey folks, I'm new to the codebase and wanted to start contributing, I took a quick look at the issue and seems like the fix is on the xterm side, is it ok if I work on this issue?

@kevinc16 kevinc16 mentioned this issue May 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@notpeelz @Tyriar @meganrogge @kevinc16 and others