Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code tunnel "--name" no longer sets the machine name when a tunnel exists #211378

Closed
LER0ever opened this issue Apr 25, 2024 · 2 comments · Fixed by #211492
Closed

code tunnel "--name" no longer sets the machine name when a tunnel exists #211378

LER0ever opened this issue Apr 25, 2024 · 2 comments · Fixed by #211492
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug code-cli insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@LER0ever
Copy link

LER0ever commented Apr 25, 2024

Does this issue occur when all extensions are disabled?: Yes (N/A)

  • VS Code Version: 1.88.1
  • OS Version: macOS

Steps to Reproduce:

  1. In the shell, run code tunnel --name {ANYTHING}, UPDATE: the system need to have a existing tunnel already running
  2. Notice that the machine name is always inferred from Hostname instead of the machine name set through --name

This only happens recently when I upgrade to 1.88, the --name option works on previous releases before the upgrade, but I'm not sure which the last working version is.

image
@LER0ever
Copy link
Author

Update: I noticed the "Connected to an existing tunnel..." line, and if I kill the tunnel first using code tunnel kill and run the same command, it would correctly set the machine name. I'll update the issue description to reflect that.

@LER0ever LER0ever changed the title code tunnel "--name" no longer sets the machine name code tunnel "--name" no longer sets the machine name when a tunnel exists Apr 25, 2024
@hediet hediet assigned connor4312 and unassigned hediet Apr 26, 2024
@connor4312
Copy link
Member

Yea, if there's an existing tunnel we just connect to it and never enter the process in which the name would be set. Renaming a running tunnel is also possible but could lead to unpredictable side effects. We should just log a warning in this case.

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug code-cli labels Apr 26, 2024
connor4312 added a commit that referenced this issue Apr 26, 2024
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Apr 26, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the April 2024 milestone Apr 26, 2024
@rzhao271 rzhao271 modified the milestones: April 2024, May 2024 Apr 29, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug code-cli insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants