Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visibleTextEditorControls in the editor service doesn't return all visible text editor controls #211357

Closed
alexr00 opened this issue Apr 25, 2024 · 0 comments
Closed

visibleTextEditorControls in the editor service doesn't return all visible text editor controls #211357

alexr00 opened this issue Apr 25, 2024 · 0 comments
Assignees
@bpasero
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Milestone
May 2024

Comments

@alexr00
Copy link
Member

alexr00 commented Apr 25, 2024

visibleTextEditorControls in the EditorService leaves out one of the text editors for each "split in group" editor.

Per #211337 (review), we could do this properly by giving the side by side editor a new control type.

The issue is surfaced in #211257, which has been worked around in #211356
@alexr00 alexr00 mentioned this issue Apr 25, 2024
Closed
bpasero added a commit that referenced this issue Apr 29, 2024
@bpasero
visibleTextEditorControls in the editor service doesn't return all …
1ea32ee 
…visible text editor controls (fix #211357)
@bpasero bpasero added this to the May 2024 milestone Apr 29, 2024
@bpasero bpasero added the debt Code quality issues label Apr 29, 2024
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Apr 29, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpasero bpasero

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
May 2024
Development

No branches or pull requests
3 participants
@bpasero @alexr00 @VSCodeTriageBot