Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When In Zen Mode the title bar doesn't get hidden due to the New "Top" mode for Activity Bar #199579

Closed
RadhiRasho opened this issue Nov 29, 2023 · 6 comments · Fixed by #211354
Closed

When In Zen Mode the title bar doesn't get hidden due to the New "Top" mode for Activity Bar #199579

RadhiRasho opened this issue Nov 29, 2023 · 6 comments · Fixed by #211354
Assignees
@benibenj
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues workbench-zen Full screen 'Zen' view issues
Milestone
May 2024

Comments

@RadhiRasho
Copy link

RadhiRasho commented Nov 29, 2023 •
edited

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.84.2
  • OS Version: Windows 10 22H2 (Build 19045.3693)

Steps to Reproduce:

  1. Open New Window of VS Code
  2. Set the Activity Bar Position to "Top"
  3. Enter Zen Mode (Command Pallete -> View: Toggle Zen Mode)
  4. Title Bar should still be there

This was tested on the latest version of VS Code Insider and Results were the same and with all Extensions Off

Expected Behavior:
Title Bar should be hidden (at least when in Zen Mode)

Possible Fix/Alternatives:

  1. Hide it in Zen Mode
  2. Add an option into the Zen Mode Settings to turn Title bar off unless the user has clicked Alt (which shows the title bar)

In Zen Mode:
image

Out Of Zen Mode:
image
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues workbench-zen Full screen 'Zen' view issues labels Dec 21, 2023
@sbatten sbatten added this to the Backlog milestone Dec 21, 2023
@bpasero
Copy link
Member

bpasero commented Apr 25, 2024 •
edited by benibenj

@RadhiRasho can you try configuring window.customTitleBarVisibility to windowed. When in Zen mode, the window goes fullscreen and the title should hide.

But maybe I am missing some context here, can you try to reproduce again.

@bpasero bpasero added the info-needed Issue requires more information from poster label Apr 25, 2024
@sandy081 sandy081 assigned benibenj and unassigned sandy081 Apr 25, 2024
@RadhiRasho
Copy link
Author

@bpasero Looks like setting the window.customTitleBarVisibility to windowed does hide it when in full screen.

I hadn't realized that, I just thought that the default behavior that was there should still be there even if the Activity bar is set to the new option of Top, shouldn't it?

That's the reason I opened this issue

@benibenj
Copy link
Contributor

You are right We are not showing the activity bar when using default position in zen mode so we also shouldn't show the title bar in zen mode when the activity bar is at the top.

@benibenj benibenj removed the info-needed Issue requires more information from poster label Apr 25, 2024
@RadhiRasho
Copy link
Author

This might be a separate issue, but it seems that when Activity Bar is in Top mode, the alt no longer switches to the menu bar.

Also the Menu Bar when it's hidden (hamburger menu in activity bar) has a bit of an alignment issue:
image

Let me know if I should move this to another issue

@benibenj
Copy link
Contributor

Please create a new issue for this. Also make sure to mention which settings/mode you are using

@benibenj benibenj modified the milestones: Backlog, May 2024 Apr 25, 2024
@RadhiRasho
Copy link
Author

New issue as mentioned above: #211353

@benibenj benibenj mentioned this issue Apr 25, 2024
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benibenj benibenj

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues workbench-zen Full screen 'Zen' view issues
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

Update shouldShowCustomTitleBar function to consider zenModeActive parameter microsoft/vscode
6 participants
@bpasero @sbatten @sandy081 @benibenj @RadhiRasho @VSCodeTriageBot