Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat progress messages are reported multiple times to screenreader #211165

Closed
roblourens opened this issue Apr 23, 2024 · 4 comments · Fixed by #211481
Closed

Chat progress messages are reported multiple times to screenreader #211165

roblourens opened this issue Apr 23, 2024 · 4 comments · Fixed by #211481
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug chat insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@roblourens
Copy link
Member

Testing #210661

  • Send a request to @workspace
  • This participant shows 3 progress messages
  • The screen reader reads them but they get read multiple times in random order

I'm not scrolling or anything, this is just what happens as the response renders normally. I'm assuming this is due to progress messages being re-rendered, and the screenreader hooking into the rendering flow

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues chat labels Apr 24, 2024
@meganrogge meganrogge added this to the April 2024 milestone Apr 24, 2024
@meganrogge meganrogge removed the bug Issue identified by VS Code Team member as probable bug label Apr 24, 2024
@meganrogge meganrogge removed this from the April 2024 milestone Apr 24, 2024
@meganrogge
Copy link
Contributor

meganrogge commented Apr 24, 2024

@roblourens I cannot reproduce (at least on macOS), I am only seeing the progress messages once and they occur when I expect them to. Can you provide a gif?

@meganrogge meganrogge added the info-needed Issue requires more information from poster label Apr 24, 2024
@roblourens
Copy link
Member Author

roblourens commented Apr 24, 2024

They each appear once, it's just that the screenreader reads them multiple times

@meganrogge
Copy link
Contributor

I don't see the screen reader reading them multiple times. Can you make a gif?

@roblourens roblourens self-assigned this Apr 26, 2024
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Apr 26, 2024
@roblourens roblourens added this to the May 2024 milestone Apr 26, 2024
@roblourens
Copy link
Member Author

It reads them once as they come in, and a second time when it reads the content of the response when the response is done. Pushing a change to not consider the progress message part of the 'content', which I think is correct since the progress messages disappear from the view once more content has loaded.

This also fixes the fact that the progress messages appear when I Copy a chat response (never noticed that before)

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug chat insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants