Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange rendering of inline key bindings in accessibility help #211061

Closed
dbaeumer opened this issue Apr 23, 2024 · 2 comments
Closed

Strange rendering of inline key bindings in accessibility help #211061

dbaeumer opened this issue Apr 23, 2024 · 2 comments
Assignees
@meganrogge
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@dbaeumer
Copy link
Member

Testing #210668

Code vscode-extension-samples\tree-view-sampleree

				{
					"id": "ftpExplorer",
					"name": "FTP Explorer",
					"accessibilityHelpContent": "This is a custom view <keybinding:ftpExplorer.refresh> to explore ftp servers "
				}

Image

IMO this should not be rendered that way.

[Configure a keybinding](command:workbench.action.openGlobalKeybindings?%22ftpExplorer.refresh%22)
@rzhao271
Copy link
Contributor

More examples

Accessibility help contribution with two keybindings and some text in between them and before and after them
When the extension is run, the first keybinding is mangled with the second one and the text in between

@meganrogge
Copy link
Contributor

yeah, it's not ideal.

/duplicate #210665

@VSCodeTriageBot VSCodeTriageBot added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dbaeumer @rzhao271 @meganrogge @VSCodeTriageBot