Terminal Image display has low resolution

[albert-ying]

Does this issue occur when all extensions are disabled?: Yes/No

• VS Code Version: 1.88.1
• OS Version: Mac: Universal Intel silicon

Steps to Reproduce:

1. imgcat "anyimage.png"

Original image:

In VScode terminal

In Iterm2 terminal

[VSCodeTriageBot]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.88.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[meganrogge]

does changing the value of terminal.integrated.gpuAcceleration fix it?

[albert-ying]

does changing the value of terminal.integrated.gpuAcceleration fix it?

No it doesnt

[Tyriar]

Upstream: xtermjs/xterm.js#5035

[jerch]

@albert-ying Whats your screen DPR on the machine, where this happens?

@Tyriar I think this is related to css pixels vs. screen pixels. The image addon currently uses css pixels for backend size propagation, thus image will blur if DPR is really high (e.g. a css pixel gets overly stretched on the screen).

[albert-ying]

It is 2 (4k screen)

[jerch]

I see, so you get only half of the pixel density compared to iterm2. Imho the measurement could be changed to account for DPR in IIP (iterm's image protocol), but I am currently unsure about implications on the sixel format. The issue is that the pixel size escape sequences work with css pixels across the whole terminal, not only for images, and I am unsure if that can easily be changed to device metrics / real screen pixels.

Lets follow that in xtermjs/xterm.js#5035