Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quickpick checkbox state not announced correctly by screen readers #210671

Closed
meganrogge opened this issue Apr 18, 2024 · 2 comments · Fixed by #211140
Closed

quickpick checkbox state not announced correctly by screen readers #210671

meganrogge opened this issue Apr 18, 2024 · 2 comments · Fixed by #211140
Assignees
@hediet
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues regression Something that used to work is now broken verified Verification succeeded
Milestone
April 2024

Comments

@meganrogge
Copy link
Contributor

  1. enable a screen reader
  2. run the Manage Trusted Extensions command.
  3. checkboxes are always read as "unchecked"
@TylerLeonhardt
Copy link
Member

bisected this to c2f0a3f @hediet can you take a look?

@TylerLeonhardt TylerLeonhardt added regression Something that used to work is now broken bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues quick-pick Quick-pick widget issues labels Apr 19, 2024
@TylerLeonhardt TylerLeonhardt added this to the April 2024 milestone Apr 19, 2024
@hediet
Copy link
Member

hediet commented Apr 23, 2024

Oops, @TylerLeonhardt next time we meet I owe you a drink! ;)

hediet added a commit that referenced this issue Apr 23, 2024
@hediet
Fixes #210671
1e6ed0a
@hediet hediet mentioned this issue Apr 23, 2024
Merged
hediet added a commit that referenced this issue Apr 23, 2024
@hediet
Fixes #210671 (#211140)
9fc58fa
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 23, 2024
@meganrogge meganrogge added the verified Verification succeeded label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hediet hediet

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Milestone
April 2024
Development

Successfully merging a pull request may close this issue.

Fixes #210671 microsoft/vscode
4 participants
@TylerLeonhardt @hediet @meganrogge @VSCodeTriageBot