Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add signalOptions group for settings so they're easier to find #210655

Closed
meganrogge opened this issue Apr 18, 2024 · 1 comment · Fixed by #211487
Closed

add signalOptions group for settings so they're easier to find #210655

meganrogge opened this issue Apr 18, 2024 · 1 comment · Fixed by #211487
Assignees
@meganrogge
Labels
accessibility-signal Issues pertaining to accessibility signals debt Code quality issues feature-request Request for new features or functionality unreleased Patch has not yet been released in VS Code Insiders
Milestone
May 2024

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Apr 18, 2024 •
edited

Right now:

accessibility.signals.sounds.volume and accessibility.signals.debouncePositionChanges

Suggestion from @hediet :

accessibility.signalOptions.{soundsVolume, debouncePositionChanges, ...} ?
@meganrogge meganrogge self-assigned this Apr 18, 2024
@meganrogge meganrogge added debt Code quality issues accessibility-signal Issues pertaining to accessibility signals labels Apr 18, 2024
@meganrogge meganrogge added this to the May 2024 milestone Apr 18, 2024
@meganrogge meganrogge added the feature-request Request for new features or functionality label Apr 26, 2024
@meganrogge
Copy link
Contributor Author

verify that if you have these:

 "audioCues.volume": 100,
  "audioCues.debouncePositionChanges": true

or these:

  "accessibility.signals.sounds.volume": 100,
  "accessibility.signals.debouncePositionChanges": true,

and reload the window, you see the migration happens successfully to signalOptions

meganrogge added a commit that referenced this issue Apr 26, 2024
@meganrogge
fix #210655
45aaef9
@meganrogge meganrogge mentioned this issue Apr 26, 2024
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
accessibility-signal Issues pertaining to accessibility signals debt Code quality issues feature-request Request for new features or functionality unreleased Patch has not yet been released in VS Code Insiders
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

add accessibility.signalOptions config, migrate settings to it microsoft/vscode
2 participants
@meganrogge @VSCodeTriageBot