Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default focus to "find" input on execute of replace #17562

Closed
frostius opened this issue Dec 19, 2016 · 4 comments
Closed

Default focus to "find" input on execute of replace #17562

frostius opened this issue Dec 19, 2016 · 4 comments
Assignees
Labels
editor-find Editor find operations under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Milestone

Comments

@frostius
Copy link

frostius commented Dec 19, 2016

Executing a replace (in file) should set default focus to "find" input field when multiple lines are selected as the find value is not set from the selection and has the value set to the previous find/replace

@egamma egamma added editor-find Editor find operations editor labels Dec 20, 2016
@mylowillem
Copy link

Yes please add a setting that controls whether or not selection is turned on by default.

@alexdima alexdima added the ux User experience issues label Mar 2, 2017
@alexdima alexdima added this to the Backlog milestone Mar 2, 2017
@alexdima alexdima added the under-discussion Issue is under discussion for relevance, priority, approach label Apr 27, 2017
@rebornix rebornix self-assigned this May 22, 2017
@rebornix rebornix modified the milestones: May 2017, Backlog May 23, 2017
@rebornix
Copy link
Member

Right now, if the current selection is not empty and not multi line, we will use current selection as search string. Since search string is determined in this way, we will focus the Replace Input.

If both current selection and existing search string in Find Widget are empty, we'll focus the Find Input as users need to type in something to search.

If you are not that satisfied with the auto-populating search string feature, let's talk about it in #20768 .

@frostius
Copy link
Author

Find/replace in vscode is possibly the least usable of any editor I've used in the last 20 years. Seriously. You haven't even bothered to support keyboard usage. You clear my selection when I try to search. You erase my previous search. You don't support find history. You have violated all the 7 pillars of search usability and have placed your eternal soul in jeopardy.

Please, pretty please, with sugar on top - assign someone to this who will give it some love

@rebornix
Copy link
Member

rebornix commented May 24, 2017

@mfrost66

You clear my selection when I try to search

We don't but as we have incremental search, once you type characters that exist in the document, the current selection will be moved to the first find result. Do you mean you actually don't like this feature?

You erase my previous search

If you don't like our populating query keyword from selection automatically, you should be able to turn it off later in settings (once we have a new version of Insiders)

You don't support find history

We support find history, alt+up/down

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-find Editor find operations under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Development

No branches or pull requests

5 participants