Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching keyboard shortcuts with 'Record Keys' does not include chords using that keybinding #158799

Closed
gjoseph92 opened this issue Aug 22, 2022 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) keybindings-editor Keybinding editor issues

Comments

@gjoseph92
Copy link

gjoseph92 commented Aug 22, 2022

Type: Feature Request

If you use 'Record Keys' in the keyboard shortcuts settings to search for a keybinding (say, because you want to see if it's available, or why it's not triggering as you'd expect), you only see exact matches for that binding, not any chords that might use it as a prefix. This can be misleading if you aren't aware of this behavior.

As a default, it might be better for 'Record Keys' to use the un-quoted search string, so chords would show up as well.

I installed an extension which added keybindings using cmd+l as the first key in a chord. When the default behavior of plain cmd+l stopped working, I searched keyboard shortcuts (using Record Keys) for "cmd+l" to see if something had overridden it. Since the extension's keybinding didn't show up in that search (since it was cmd+l cmd+o), I believed something more complex was going on, and went through a whole extension bisect to realize that it was indeed just a simple keybinding issue.

Example:

  • Using 'Record Keys', search for a keybinding that you know is the prefix for a chord. For example, on macOS using the default VS Code keybindings, "cmd+k" is the first shortcut in many, many chords.
  • Notice that only shortcuts using the exact binding "cmd+k" show up, not all the bindings that start with that prefix.
  • If you remove the quotes (cmd+k), then all matches show up, including chords.

VS Code version: Code 1.70.2 (e4503b3, 2022-08-16T05:36:37.829Z)
OS version: Darwin x64 20.6.0
Modes:

@sandy081 sandy081 added the keybindings-editor Keybinding editor issues label Aug 25, 2022
@sandy081
Copy link
Member

/duplicate

#88122

@VSCodeTriageBot VSCodeTriageBot added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 25, 2022
@VSCodeTriageBot
Copy link
Collaborator

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) keybindings-editor Keybinding editor issues
Projects
None yet
Development

No branches or pull requests

3 participants