Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the markdown preview custom editor #138040

Closed
2 tasks done
mjbvz opened this issue Nov 29, 2021 · 2 comments
Closed
2 tasks done

Test the markdown preview custom editor #138040

mjbvz opened this issue Nov 29, 2021 · 2 comments

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 29, 2021

Test for #84520

Complexity: 5

Create Issue


This is an exploratory test plan item for the markdown preview custom editor. This allows you to use reopen with to reopen the current document as a markdown preview instead of as a normal text editor .

For this test plan item, please try using the new preview editor and seeing what doesn't work as expected. Some specific things to try:

  • Try using reopen with to switch a text document to a markdown preview

  • Try configuring workbench.editorAssociations to use the preview by default:

    "workbench.editorAssociations": {
      "*.md": "vscode.markdown.preview.editor"
    }
    
  • Make sure clicking on links works as expected using the new markdown preview.

    Try using the vscode-docs repo since it has lots of links between files (images will not load since they use git LFS)

  • Make sure scroll positions are restored properly when reloading a window or switching away from an editor and back

  • Make sure scroll sync is disabled for preview based custom editors

@sandy081
Copy link
Member

Make sure scroll sync is disabled for preview based custom editors

Do you mean between preview & custom editor?

@rchiodo
Copy link
Contributor

rchiodo commented Nov 30, 2021

Make sure scroll sync is disabled for preview based custom editors

This seems to be sync'd so I'm also not sure what this means. Do you mean between 'Open Preview' and the editor we're testing?

The scroll position is sync'd as long as the two editors aren't visible at the same time.

@rchiodo rchiodo removed their assignment Nov 30, 2021
@rchiodo rchiodo closed this as completed Nov 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants