Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test UI] What's the usage of 'Show in Active File Only' #128824

Closed
jdneo opened this issue Jul 16, 2021 · 5 comments
Closed

[Test UI] What's the usage of 'Show in Active File Only' #128824

jdneo opened this issue Jul 16, 2021 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Milestone

Comments

@jdneo
Copy link
Member

jdneo commented Jul 16, 2021

Version: 1.59.0-insider (user setup)
Commit: 50b3811
Date: 2021-07-15T05:13:58.348Z
Electron: 13.1.6
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Windows_NT x64 10.0.19043

@connor4312 Maybe I missed something. There is a menu called Show in Active File Only in the test view, what's the usage of that option? I tried to enable/disable it, but nothing happens.

image

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels Jul 16, 2021
@connor4312 connor4312 added this to the July 2021 milestone Jul 16, 2021
@jdneo
Copy link
Member Author

jdneo commented Jul 21, 2021

@connor4312 Is this option only works for the top level test items? (test items that belongs to testController.items)

When the test item is a deeper one, seems it won't appear

testing.mp4

@connor4312
Copy link
Member

The algorithm used for showing tests is:

  1. If the current file has a URI: if the URI is parent of or equal to the current file show it, otherwise hide it.
  2. If the current file does not have a URI, recurse this algorithm for its children. If any children are visible, this item is visible too

@jdneo
Copy link
Member Author

jdneo commented Jul 23, 2021

Thanks for the explanataion. @connor4312

Sounds like if the test node's uri contains or equal to the current file's uri, then it will be shown in the explorer?

If that's true, could you try this change? jdneo/vscode-extension-samples@d0e96ee

I add a folder layer for each file. But they are not appear when Show in Active File enabled

@roblourens
Copy link
Member

That option is gone now, is that expected?

@roblourens roblourens added the verification-steps-needed Steps to verify are needed for verification label Jul 29, 2021
@connor4312
Copy link
Member

Make sure you're looking in the "filter" menu in the search box; it's still there.

Thanks for the repro Sheng! Fixed in the next Insiders.

@roblourens roblourens added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Jul 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@roblourens @connor4312 @jdneo and others