Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook suggest icons are no longer colored #128798

Closed
canersnli opened this issue Jul 15, 2021 · 4 comments
Closed

Notebook suggest icons are no longer colored #128798

canersnli opened this issue Jul 15, 2021 · 4 comments
Assignees
@rebornix @miguelsolorio
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons insiders-released Patch has been released in VS Code Insiders notebook suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone
July 2021

Comments

@canersnli
Copy link

canersnli commented Jul 15, 2021 •
edited

Environment data

  • VS Code version: 1.59 Insiders
  • Jupyter Extension version (available under the Extensions sidebar): 2021.8.1033311975
  • Python Extension version (available under the Extensions sidebar): v2021.6.944021595
  • OS (Windows | Mac | Linux distro) and version: Windows 10
  • Python and/or Anaconda version: Python 3.9.6
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
  • Jupyter server running: Local | Remote | N/A local

Expected behaviour

Colored icons like I see while editing on .py file
renkli

Actual behaviour

All icons are gray on jupyter notebook
color

Steps to reproduce:

Logs

Output for Jupyter in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Jupyter) 

XXX

@DonJayamanne DonJayamanne removed their assignment Jul 16, 2021
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-jupyter Jul 16, 2021
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Jul 16, 2021
@vscodebot
Copy link

vscodebot bot commented Jul 16, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@miguelsolorio miguelsolorio self-assigned this Jul 16, 2021
@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete notebook labels Jul 16, 2021
@miguelsolorio miguelsolorio added this to the July 2021 milestone Jul 16, 2021
@miguelsolorio miguelsolorio mentioned this issue Jul 16, 2021
Open
@miguelsolorio
Copy link
Contributor

I believe this is a result from #126514, will need to add a css class to inherit icon colors

@miguelsolorio
Copy link
Contributor

This should be fixed now:

CleanShot 2021-07-16 at 08 51 45@2x

cc @jrieken

@miguelsolorio miguelsolorio added the icons-product Issues for in-product icons label Jul 16, 2021
@miguelsolorio miguelsolorio changed the title Icons are no longer colored Notebook suggest icons are no longer colored Jul 16, 2021
@roblourens roblourens added the verified Verification succeeded label Jul 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@miguelsolorio miguelsolorio

Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons insiders-released Patch has been released in VS Code Insiders notebook suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Milestone
July 2021
Development

No branches or pull requests
6 participants
@roblourens @rebornix @DonJayamanne @miguelsolorio @canersnli and others