Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Terminal editors #127192

Closed
3 tasks done
Tyriar opened this issue Jun 25, 2021 · 2 comments
Closed
3 tasks done

Test: Terminal editors #127192

Tyriar opened this issue Jun 25, 2021 · 2 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 25, 2021

Refs: #10546 #125514

Complexity: 5

Authors: @Tyriar, @meganrogge

Create Issue


Terminals can now be moved to editor groups, there are a few ways to do this:

  • Drag a terminal tab into an editor group
  • Right click a terminal tab and select move into editor group
  • Run either Create Terminal Editor or Move Terminal into Editor Group commands
  • Set "terminal.integrated.defaultLocation": "editor"
    Before creating issues please read the philosophy section of the plan item to get an understanding of what's expected - feedback is welcome of course.

Please do some exploratory testing around the editors, here are some things to get you started and keep an eye on:

  • During development we ran into these issues a few times
    • Reloading the window would sometimes shuffle the terminals randomly
    • The terminal panel would be empty when terminal editors were used
    • Some terminal commands wouldn't work as expected in editors and/or the panel
  • Does the terminal extension API work in terminal editors and are events fired correctly?
  • Editor tab icon, color and status show up correctly
  • Terminal status information shows up when hovering editor tabs
  • Terminal editors should always be pinned
  • Does ctrl+w close the tab as expected on Windows and Linux? It's meant to close the tab and not send ^w to the terminal by default
  • Does split editor work?
  • Does the add terminal editor action button and dropdown work?
  • Does process reconnection work after reload?
  • Different environments:
    • Remote extensions
    • Codespaces
    • Live share
@Tyriar Tyriar added this to the June 2021 milestone Jun 25, 2021
@weinand
Copy link
Contributor

weinand commented Jun 29, 2021

The term "Terminal Editor" sounds rather strange.
Is there a functional difference between an "Integrated Terminal" and a "Terminal Editor" (other than its container)? Since terminals can be freely moved between the panel area and the editor area, I don't think so, right?
It would make more sense to me if the "Create Terminal Editor" command would be called "Create Terminal in Editor area"

@Tyriar
Copy link
Member Author

Tyriar commented Jun 29, 2021

@weinand sounds good to me, "Terminal Editor" is the internal term and that was the first command we added to get started. We're using this "in editor area/group" in this command and the context menus already:

Screen Shot 2021-06-29 at 8 51 45 AM

@andreamah andreamah removed their assignment Jun 29, 2021
@weinand weinand removed their assignment Jun 30, 2021
@lszomoru lszomoru removed their assignment Jul 1, 2021
@lszomoru lszomoru closed this as completed Jul 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants