Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render invisibles with replacement characters in diff editors #126950

Closed
AfsalInovicsTech opened this issue Jun 23, 2021 · 17 comments
Closed

Render invisibles with replacement characters in diff editors #126950

AfsalInovicsTech opened this issue Jun 23, 2021 · 17 comments
Assignees
Labels
diff-editor Diff editor mode issues feature-request Request for new features or functionality

Comments

@AfsalInovicsTech
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version:
  • OS Version:

Steps to Reproduce:

1.Check these strings

let update_consultation_api = this.baseUrl + `​/appointments​/${appointment_id}​/consultations​/${consultation_id}​/`
let read_consulatation_api = this.baseUrl + `/appointments/${appointment_id}/consultations/${consultation_id}/`
  1. When i compare both these strings it was not matching
  2. Then i paste this on sublime text it was different text it show a '​' character
  3. I think this is a serious issue please check
@bpasero
Copy link
Member

bpasero commented Jun 23, 2021

When i compare both these strings it was not matching

How?

@bpasero bpasero added the info-needed Issue requires more information from poster label Jun 23, 2021
@AfsalInovicsTech
Copy link
Author

AfsalInovicsTech commented Jun 23, 2021 via email

@bpasero
Copy link
Member

bpasero commented Jun 23, 2021

?

@bpasero bpasero self-assigned this Jun 23, 2021
@AfsalInovicsTech
Copy link
Author

AfsalInovicsTech commented Jun 23, 2021 via email

@bpasero
Copy link
Member

bpasero commented Jun 23, 2021

/gifPlease

@yume-chan
Copy link
Contributor

There is a \u200b (zero width space) after the first `

@AfsalInovicsTech
Copy link
Author

AfsalInovicsTech commented Jun 23, 2021 via email

@bpasero
Copy link
Member

bpasero commented Jun 23, 2021

@AfsalInovicsTech

I have attached a screenshot for your reference.

No, you didn't.

The result of this code was false.

You still did not explain what you do exactly, step by step so that I can reproduce.

@yume-chan
Copy link
Contributor

Note: GitHub doesn't accept image uploads from emails, please upload from web interface or mobile Apps.

@yume-chan
Copy link
Contributor

yume-chan commented Jun 23, 2021

#116939

EDIT: #2878, #58252

@AfsalInovicsTech
Copy link
Author

AfsalInovicsTech commented Jun 23, 2021 via email

@thebinarysearchtree
Copy link
Contributor

thebinarysearchtree commented Jun 23, 2021

I believe they are referring to the fact that when you have the first string in one file, and the second string in another file, comparing the two files does not highlight the zero width character that is only present in one of the strings.

Screen Shot 2021-06-23 at 4 42 40 pm

@bpasero bpasero assigned alexdima and unassigned bpasero Jul 9, 2021
@bpasero bpasero added diff-editor Diff editor mode issues and removed info-needed Issue requires more information from poster labels Jul 9, 2021
@alexdima alexdima changed the title Same strings not matching Render zero width spaces with a replacement character in diff editors Jul 9, 2021
@alexdima alexdima added the feature-request Request for new features or functionality label Jul 9, 2021
@thebinarysearchtree
Copy link
Contributor

thebinarysearchtree commented Jul 14, 2021

There will be a lot more than just the zero width space that don't show up. It will also depend on what font is being used. For example, the variant selectors may either show up as a variant of an emoji, or an invisible character, depending on the font and the preceding character. Other characters that are zero width include zero width joiners, etc.

@alexdima alexdima changed the title Render zero width spaces with a replacement character in diff editors Render invisibles with replacement characters in diff editors Jul 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
diff-editor Diff editor mode issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

6 participants
@bpasero @thebinarysearchtree @yume-chan @alexdima @AfsalInovicsTech and others